Accept name filters and exclusions in --export - #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--exportis now a comma-separated list instead of theall/noneenum. Existing--export=alland--export=nonebehave as before.exportkeyword. It matches the short or namespaced name (add,M.add) and accepts globs (M.*).!nameexcludes a name and always wins over an including filter. With only exclusions (--export=!sub) theexportkeyword decides, minus the excluded names.export let a, bstatement is decided on its own.MLIRExportFilter.h(isExportedByFilters), used bygetExportModifier.Example:
--export=M.*,!M.internal*,!M.bNote: in bash, quote values containing
!('--export=!sub').Test plan
ExportFilterTestunit tests (7) pass;MLIRGenTests66/66llvm-objdump -pfor no option,none,M.add,sub,!subandM.*,!M.internal*,!M.b: each exports exactly the expected symbols, including per-variable filtering ofexport let a = 1, b = 2--export=allon a DLL that uses the default lib fails to link (LNK1242, a default-lib generic instantiation gets an invalid export name). A compiler built before this change fails the same way.🤖 Generated with Claude Code