Include the version in release archive names - #316
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Release archives now carry the version in their file names, taken from the pushed tag:
v0.0-pre-alpha83)tslang.ziptslang-v0.0-pre-alpha83.ziptslang.tar.gztslang-v0.0-pre-alpha83.tar.gzHow
create-release.ymlgets a workflow-levelASSET_NAME: tslang-${{ github.ref_name }}, used wherever the archive name was hardcoded: the Windows zip and Linux tar.gz creation, the artifact upload/download between jobs, and the release asset upload. The workflow only runs onv*tag pushes, sogithub.ref_nameis always the tag.Notes
docs/compiler-explorer/infra/bin/yaml/typescript.yamlstill downloadstslang.tar.gz. It is left unchanged because it is pinned to0.0-pre-alpha20, whose asset has the old name; point its URL attslang-v{name}.tar.gzwhen moving it to a newer release.🤖 Generated with Claude Code