Repository navigation
Target the WinForms samples at Windows 10 so their packages restore cleanly - #2421
Merged
Merged
Conversation
…leanly Part of #542. SkiaSharp.Views.WindowsForms 3.119.0, which ScottPlot.WinForms brings in, ships .NET assets only for net8.0-windows10.0.19041. A project targeting net10.0-windows (Windows 7.0) cannot use them, so NuGet fell back to the .NETFramework 4.6.2 assets and their dependencies, OpenTK and OpenTK.GLControl 3.1.0, raising NU1701 three times in each sample. Targeting net10.0-windows10.0.19041.0 selects the .NET assets, which depend on OpenTK 4.8.2 and OpenTK.GLControl 4.0.1 instead; both samples restore and build with no warning. Also spell `dotnet run --project` in the C++ build, where `-p` raised NETSDK1174. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2421 +/- ##
==========================================
- Coverage 86.82% 86.81% -0.01%
==========================================
Files 312 312
Lines 69523 69523
Branches 20305 20305
==========================================
- Hits 60360 60357 -3
- Misses 4930 4932 +2
- Partials 4233 4234 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #542.
What #542 asked for is mostly already done. NU1903 was fixed in #797 and #2115–#2117, and NU1608 was settled in #1132. Re-measured on master 6d5f175, here is what's left. Locally I restored all 36 projects; on CI I read the logs of all 13 workflow runs.
CPPBuild.yml,dotnet run -p Utils-pis deprecated fordotnet runThe NU1701s come from the samples' target framework, not from ScottPlot, which the thread had suspected. SkiaSharp.Views.WindowsForms 3.119.0 ships .NET assets only for
net8.0-windows10.0.19041.net10.0-windowsmeans Windows 7.0, so NuGet fell back to the .NETFramework 4.6.2 assets, and those depend on OpenTK 3.1.0. Targetingnet10.0-windows10.0.19041.0selects the .NET assets instead, which depend on OpenTK 4.8.2 and OpenTK.GLControl 4.0.1. Both samples now restore and build with no warnings and no vulnerable packages.The samples aren't shipped as packages, so no user's dependency graph changes. The cost is that the samples now need Windows 10 2004 or later. Neither sample uses OpenTK directly, but nobody has launched GraphicExample on Windows since the change. CI only builds it.
Not changed:
Microsoft.DotNet.ILCompiler10.0.10. It appears only with an SDK older than 10.0.404, which pulls in the vulnerable runtime pack. CI's SDK resolves 10.0.15 and is clean. Pinning the package would undo Let the SDK pick the ILCompiler version, fixing the native build on master #674.🤖 Generated with Claude Code