Skip to content

Target the WinForms samples at Windows 10 so their packages restore cleanly - #2421

Merged
Rafael-SOWNet merged 1 commit into
masterfrom
feature/dependency-warnings-542
Nov 13, 2026
Merged

Rafael-SOWNet merged 1 commit into
masterfrom
feature/dependency-warnings-542

Conversation

@Rafael-SOWNet

Copy link
Copy Markdown
Member

Closes #542.

What #542 asked for is mostly already done. NU1903 was fixed in #797 and #2115–#2117, and NU1608 was settled in #1132. Re-measured on master 6d5f175, here is what's left. Locally I restored all 36 projects; on CI I read the logs of all 13 workflow runs.

Warning Where Cause
NU1701 ×3 per sample (36 lines in CI's solution build) AngouriMathPlot, GraphicExample See below
NETSDK1174 ×3 CPPBuild.yml, dotnet run -p Utils -p is deprecated for dotnet run

The NU1701s come from the samples' target framework, not from ScottPlot, which the thread had suspected. SkiaSharp.Views.WindowsForms 3.119.0 ships .NET assets only for net8.0-windows10.0.19041. net10.0-windows means Windows 7.0, so NuGet fell back to the .NETFramework 4.6.2 assets, and those depend on OpenTK 3.1.0. Targeting net10.0-windows10.0.19041.0 selects the .NET assets instead, which depend on OpenTK 4.8.2 and OpenTK.GLControl 4.0.1. Both samples now restore and build with no warnings and no vulnerable packages.

The samples aren't shipped as packages, so no user's dependency graph changes. The cost is that the samples now need Windows 10 2004 or later. Neither sample uses OpenTK directly, but nobody has launched GraphicExample on Windows since the change. CI only builds it.

Not changed:

  • NU1903 on Microsoft.DotNet.ILCompiler 10.0.10. It appears only with an SDK older than 10.0.404, which pulls in the vulnerable runtime pack. CI's SDK resolves 10.0.15 and is clean. Pinning the package would undo Let the SDK pick the ILCompiler version, fixing the native build on master #674.
  • Deprecated and outdated packages. These show up when listing packages; they aren't build warnings:
    • xunit 2.4.1 in four test projects.
    • Analyzers' System.Collections.Immutable preview.
    • In the shipped packages, GenericTensor, PeterO.Numbers, System.Memory and FSharp.Core have newer versions. Each bump changes what users install, so each should be its own measured PR.

🤖 Generated with Claude Code

…leanly

Part of #542.

SkiaSharp.Views.WindowsForms 3.119.0, which ScottPlot.WinForms brings in,
ships .NET assets only for net8.0-windows10.0.19041. A project targeting
net10.0-windows (Windows 7.0) cannot use them, so NuGet fell back to the
.NETFramework 4.6.2 assets and their dependencies, OpenTK and
OpenTK.GLControl 3.1.0, raising NU1701 three times in each sample.
Targeting net10.0-windows10.0.19041.0 selects the .NET assets, which depend
on OpenTK 4.8.2 and OpenTK.GLControl 4.0.1 instead; both samples restore
and build with no warning.

Also spell `dotnet run --project` in the C++ build, where `-p` raised
NETSDK1174.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.81%. Comparing base (6d5f175) to head (0690887).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
- Coverage   86.82%   86.81%   -0.01%     
==========================================
  Files         312      312              
  Lines       69523    69523              
  Branches    20305    20305              
==========================================
- Hits        60360    60357       -3     
- Misses       4930     4932       +2     
- Partials     4233     4234       +1     
Flag Coverage Δ
cpp 37.77% <ø> (ø)
csharp 87.35% <ø> (-0.01%) ⬇️
fsharp 32.97% <ø> (ø)
interactive 39.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rafael-SOWNet
Rafael-SOWNet merged commit bbf56b5 into master Nov 13, 2026
31 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AngouriMath Nov 13, 2026
@Rafael-SOWNet
Rafael-SOWNet deleted the feature/dependency-warnings-542 branch November 13, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fix dependencies warnings

1 participant