Repository navigation
Skip execution of subrules when conditional parent rule is skipped - #602
Merged
chetan-rathore merged 2 commits intoOct 6, 2026
Conversation
Add a rule-based precheck entry for S_L6PCI_1 that uses g_pcie_integrated_devices to detect when integrated PCIe devices are absent. Propagate TEST_SKIP from alias prechecks so skipped aliases do not expand their child rule lists. This prevents B_REP_1 and B_IEP_1 from running when the S_L6PCI_1 precheck determines the rule is not applicable. Change-Id: I3fb40f6dd17a630a9dc5d6b0f063d377d67bfece
Add rule-based precheck entries for B_REP_1 and B_IEP_1. B_REP_1 now expands only when an RCiEP or RCEC device is present, and B_IEP_1 now expands only when an iEP endpoint or iEP root port is present. This keeps S_L6PCI_1 applicable when any integrated PCIe device exists while preventing unrelated integrated PCIe branches from running against the normal PCI exerciser path. Change-Id: If0ffcba7c008e2f12233c372d2172b2c4cad0bf9
chetan-rathore
merged commit Oct 6, 2026
587b2ec
into
ARM-software:release/sbsa/v8.0.3
29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes rule-based execution for integrated PCIe alias rules.
Previously, S_L6PCI_1 expanded its child aliases even when PCIe discovery found no integrated PCIe devices. That caused integrated PCIe subrules to run against normal PCIe exerciser endpoints.
Updates:
Add an S_L6PCI_1 precheck to skip the alias when no integrated PCIe devices are present.
Propagate SKIP from alias prechecks so skipped aliases do not expand child rules.
Add B_REP_1 and B_IEP_1 prechecks so each integrated PCIe branch only expands when matching device types exist:
B_REP_1: RCiEP/RCEC
B_IEP_1: iEP_EP/iEP_RP
This keeps normal PCIe tests running while preventing non-applicable integrated PCIe subrules from executing.