Repository navigation
ENH: Corrections to gradient pblh schemes, updates to examples - #1070
Merged
Merged
Conversation
zssherman
reviewed
Oct 9, 2026
zssherman
approved these changes
Oct 12, 2026
AdamTheisen
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Gradient PBLH schemes have been corrected to reflect literature standards, mainly defining the PBLH as the "sharpest negative gradient". Previously, the scheme was coded as the "first negative gradient".
Additional maximum height constraints have been added to both schemes for consistency with other ACT PBLH schemes.
Examples recreated to use the miniMPL from the SGP-REAL activity, for the 30 March IOP. This date was selected as it is completely cloud free REAL-IOP. This also corrects ACT's PBLH examples for wavelet and gradient schemes, which previously used a cloud capped SGP ceilometer example.
Why
During analysis for the SGP-REAL activity, it was noted the gradient schemes should be corrected to reflect literature standards.
Additionally, examples should use realistic examples and not instances were the retrieval is not valid for, such as cloud-capped PBLs.
Issues closed
N/A
Validation
Mark each item as done or N/A. Add one short evidence line for each item.
I ran pre-commit or ruff
I ran tests and/or added tests
AI usage & manual verification
If AI tools were used, complete this section.
Impact note (optional):