Repository navigation
FIX: Update for how dimensions are handled for xarray 202609. - #1069
Merged
Merged
Conversation
Collaborator
|
@zssherman I think we can go ahead with this. The differences with what's reported by the CEIL itself is due to vendor calculations and settings provided. I think we can keep as you have it and I'll look at improving the tests, examples, and code in the future |
Collaborator
Author
|
Sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
2-4 bullets in plain language.
Why
we were indexing by 1, which now we have to specify
Validation
Mark each item as done or N/A. Add one short evidence line for each item.
I ran pre-commit or ruff
I ran tests and/or added tests
AI usage & manual verification
If AI tools were used, complete this section.
Use Xarray Dataset naming
When adding dataset usage to the code use ds for Datasets and da for
DataArrays
Impact note (optional): breaking behavior, scientific output shift, or user-visible behavior.