Metric to Development Pull Request by DK-ombudsman · Pull Request #134 · AMReX-Astro/Emu

DK-ombudsman · 2026-08-28T13:37:35Z

No description provided.

…d of interpolate_rhs_from_mesh to use Metric.H

…ack to the previous prescription.

…hs function

…he particle.

…y to x,y,z

… spherical FD reflecting test

srichers · 2026-08-28T13:40:45Z

@@ -0,0 +1,86 @@
+'''


for constant backgrounds, there is an option in emu to specify the rho/T/Ye in the parameter file without creating a background file. That might be the more simple way to do it to minimize the amount of code that needs to be maintained.

srichers · 2026-08-28T13:41:29Z

@@ -1,5 +1,5 @@
 #!/bin/bash
-for f in $(grep -rIPl "\t" ../../Source)
+for f in $(grep -rIl $'\t' ../../Source)


why was this changed?

That was committed by mistake. That's a change which is particular to my macOS system

srichers · 2026-08-28T13:44:11Z

    if (parms->cfl_factor > 0.0) {
+        Real min_length;
+
+        if (parms->coord_sys == 0) {


rather than having an if statement here, it should just ask the metric about the min length. That way the only if statement is the one that chooses the metric.

srichers · 2026-08-28T13:44:37Z

+                                   p.rdata(PIdx::pupz) / p.rdata(PIdx::pupt)};
+
+            // For curvilinear coordinates, we convert phat to curvilinear components projected on a local orthonormal tetrad for each particle
+            if (parms->coord_sys != 0) {


rather than having if statements here, this should just be a function contained in the metric. That way the only if statement is the one that chooses the metric.

the cartesian metric can trivially just return without doing anything

srichers · 2026-08-28T13:46:54Z

+
+                FourVec pos_int;
+
+                if (coord_sys == 0) {


same statement regarding if statements - this logic should be in the metric class.

srichers · 2026-08-28T13:47:02Z

                    mode == BoundaryCondition::outflow) {
                    p.pos(d) = reflected_pos;
+
+                    if (parms->coord_sys == 0) {


same statement regarding if statements - this logic should be in the metric class.

srichers · 2026-08-28T13:47:08Z

+
                    p.rdata(PIdx::pupx + d) = -p.rdata(PIdx::pupx + d);

+                    if (parms->coord_sys == 0) {


same statement regarding if statements - this logic should be in the metric class.

srichers · 2026-08-28T13:47:22Z

+
+                //calculating cell volume
+                amrex::Real V_cell;
+                if (coord_sys == 0) {


same statement regarding if statements - this logic should be in the metric class.

cellio00 · 2026-09-01T02:49:09Z

I have not yet weighed in on the PR until Debraj/Sherwood finish their discussions from Sherwood's review. Just as an update!! I have seen it, just waiting for my turn.

…ackground generator

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X4d9PEZdQvr3LGj1RALd1U

srichers

Overall, looks good. Only a couple of small modifications to apply.

srichers · 2026-09-15T12:51:28Z


+                    metric.coord_conv_inv(p);
+
+                    // p.rdata(PIdx::pupx) = p.rdata(PIdx::pupx) + 0.05*p.rdata(PIdx::pupt);


If this is not used, should we delete the code?

Yes. deleted.

srichers · 2026-09-15T12:52:41Z

                for (int j = sy.first(); j <= sy.last(); ++j) {
                    for (int i = sx.first(); i <= sx.last(); ++i) {
+                        // getting the upper and lower bounds of the cell
+                        const amrex::Real x1_lo = plo[0] + i / dxi[0];


this code is repeated below, so I think we should turn it into a function.

It does not have any coordinate system components to it ( so it's same for all coordinate systems). Should the function still be in metric or where should I put the function?

…he upper and lower bounds of the cell

cellio00

I approve of these changes; however It looks like there are requested changes still.

DK-ombudsman and others added 30 commits June 5, 2026 17:19

Included more general d(lamba)- dt relation : (-p.n)

db73a00

Simplified the -p.u part

87e225f

Added comment to -p.u part

08a3049

Added Metric.H to Evolve.cpp and changed the the normal rhs at the en…

cdea116

…d of interpolate_rhs_from_mesh to use Metric.H

Added option to select coordinate system from input files

e88bf91

Added if condition to check coordinate system before writing the rhs

9b48f4c

Stop tracking Exec .DS_Store

e3e4c7c

make metric functions live on host and device

d495b2f

Making it run on both CPU and GPU. Also, changing the geodesic_rhs b…

858df60

…ack to the previous prescription.

Added cell volume correction to deposit_to_mesh

c75b86e

added volume corrections to particle initialisation

2a7b850

Made the dx/dt and dp/dt always defined in cartesian using geodesic_r…

8a3382f

…hs function

removed commented out scale_fac

130477b

removed location syncing in coord_conv-inv

a42ce37

Passing parms->coord_sys to SyncLocation

a697506

fixed SyncLocation to handle curvilinear mesh

b157b3e

Additional function to change position coordinates without mutating t…

03a6fda

…he particle.

Applies metric corrections to SyncLocation

be0bd18

Added metric corrections to dt_translation inside Compute_dt

a9162ce

merged with development

884db6f

changed tab_exterminator to work on macOS

0bd746d

Applied formatting

e5690cd

fix formatting

1d30337

updated .gitignore files

2d1ec97

changed x_cm, y_cm, z_cm in Source/ReadHDF5RhoYeT.cpp to x,y,z

6592d0e

Modified the dt_translation inside compute_dt for spherical coordinates

cd3976f

changed x_cm, y_cm, z_cm in nsm_constant_background_rho_Ye_T_writer.p…

d79299b

…y to x,y,z

Added the 1D spherical FD reflecting test in Jenkinsfile

7680163

Added nsm_constant_background_rho_Ye_T_writer_spherical.py for the 1D…

a143262

… spherical FD reflecting test

Added input file for 1D spherical FD reflecting test

d835654

DK-ombudsman added 7 commits August 27, 2026 05:53

some comments

c11bc4e

Added test for the local tetrad

015c49a

Correct test parameters

3d46df1

Merge remote-tracking branch 'origin/development' into metric

1bf929b

inbuilt create_grid

3549dfe

clang formattng

2f08db8

clang format

9e6a148

DK-ombudsman requested a review from cellio00 August 28, 2026 13:37

DK-ombudsman closed this Aug 28, 2026

Added Radiating Sphere test to Jenkinsfile

a5581cd

srichers reviewed Aug 28, 2026

View reviewed changes

DK-ombudsman reopened this Aug 31, 2026

DK-ombudsman and others added 11 commits September 1, 2026 13:54

Added the constant background in the insput files rather than using b…

850922f

…ackground generator

no longer using background writer for FD spherical test

c799770

removed background generator for FD spherical test

9dcc2ba

Changed it to compile emu with curvilinear coordinates where needed

08152c8

Added defailt COORD_SYS as cartesian

8843f06

Added compile time coordinate system hard coding in the EMU codebase

ee9d7d7

Removed a stale code

def808b

Chnaged the vol function argument to x_min, x_max

ddd13c3

reverted the tab exterminator back to original

5e277be

formatting changes

bdc4fd6

Ignore Exec/run_logs/ directory

298f116

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X4d9PEZdQvr3LGj1RALd1U

srichers requested changes Sep 15, 2026

View reviewed changes

DK-ombudsman added 3 commits September 15, 2026 13:58

deleted stale code

b7f2d8c

Change plo to p_lo for naming consistency. Added a function to fund t…

ec5bdfa

…he upper and lower bounds of the cell

conflicts resolved

1dc0e3c

cellio00 approved these changes Sep 17, 2026

View reviewed changes

cellio00 requested a review from srichers September 17, 2026 21:33


		p.rdata(PIdx::pupx + d) = -p.rdata(PIdx::pupx + d);

		if (parms->coord_sys == 0) {


		metric.coord_conv_inv(p);

		// p.rdata(PIdx::pupx) = p.rdata(PIdx::pupx) + 0.05*p.rdata(PIdx::pupt);

Conversation

DK-ombudsman commented Aug 28, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cellio00 commented Sep 1, 2026

Uh oh!

srichers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cellio00 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants