ci: track test flavor in per-test baseline and rename job to Track Test Duration - #4659
Draft
hsuan-lun-chiang wants to merge 9 commits into
Draft
ci: track test flavor in per-test baseline and rename job to Track Test Duration#4659hsuan-lun-chiang wants to merge 9 commits into
hsuan-lun-chiang wants to merge 9 commits into
Conversation
…st Duration Track hardware (test flavor) for each test duration in per_test_baseline.json using key format `flavor::test_name` to prevent cross-hardware baseline comparison noise. Also rename job and workflow from "Track Test Performance" to "Track Test Duration".
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses hardware-dependent test duration noise in the Per-Test Baseline comparison and updates workflow job naming.
Problem & Context
Previously,
per_test_baseline.jsontracked test durations using un-flavored test names. When a test ran on multiple hardware platforms with different execution times (e.g.,QKClipMLATest.test_mla_dot_product_integrationtaking 0.94s on CPU vs 15.99s on GPU), baseline comparison falsely flagged regressions when comparing across hardware types.Solution
per_test_baseline.jsonare now formatted asflavor::test_name(e.g.,gpu-unit::tests.unit.qk_clip_test...), isolating durations for each hardware flavor.new_per_test_baseline.json.Track Test PerformancetoTrack Test Durationintrack_performance.ymlandci_pipeline.yml.tests/utils/process_test_results_test.pyto verify per-flavor baseline isolation and regression checking.Tests
Ran local unit tests and pre-commit hooks:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.