FUTURE_COPYBARA_INTEGRATE_REVIEW=https://github.com/AI-Hypercomputer/maxtext/pull/4513 from Shuwen-Fang:sort_one_sparsecore cccf4ecd7360fbb63557537ccc731eb4f5d0b102 - #4657
Merged
Conversation
`load_dynamic.py` imports `google.cloud.storage` at module scope, which breaks pytest collection of `tests/unit/checkpointing_test.py` in decoupled mode (`DECOUPLE_GCLOUD=TRUE`), where `google-cloud-storage` is intentionally not installed. Same failure and same fix as #4003 for `utils/utils.py`, following the existing `gcloud_stub` pattern. - `load_dynamic.py`: bind `storage = gcs_storage()` instead of importing `google.cloud.storage` directly. - `checkpointing_test.py`: three tests patched `google.cloud.storage.Client`, which cannot be resolved when the package is absent. Patch the module-level `load_dynamic.storage` binding instead, matching the existing `gcs_storage` test in the same file. Non-decoupled behavior is unchanged: `gcs_storage()` returns the real `google.cloud.storage` module when it is installed.
copybara-service
Bot
requested review from
Lumosis,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
gagika,
gobbleturk,
gpolovets1,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
jrplatin,
khatwanimohit,
mailvijayasingh,
michelle-yooh,
mitalisi,
parambole,
patemotter,
richjames0,
shralex,
shuningjin,
suexu1025,
vipannalla and
xibinliu
as code owners
July 29, 2026 04:20
copybara-service
Bot
requested review from
A9isha and
dipannita08
as code owners
July 29, 2026 04:20
copybara-service
Bot
force-pushed
the
test_955639639
branch
from
July 29, 2026 04:21
95a53c7 to
f44adf2
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…c-gcs PiperOrigin-RevId: 955940966
copybara-service
Bot
force-pushed
the
test_955639639
branch
from
July 29, 2026 17:14
f44adf2 to
484fec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#4513 from Shuwen-Fang:sort_one_sparsecore cccf4ec