Warn when running on the Linen code path - #4654
Draft
ecnal-cienet wants to merge 1 commit into
Draft
Conversation
Linen is slated for deprecation, but nothing tells users when they are on it. Setting any of enable_nnx, pure_nnx or pure_nnx_decoder to False selects Linen, including partial combinations such as pure_nnx_decoder=False alone, which silently bridges a Linen decoder that Qwix cannot see. Log a banner from config validation listing exactly which flags selected the Linen path, and note the upcoming deprecation in the three field descriptions. The check lives in the Pydantic model validator so it covers every entry point rather than just train.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
xibinliu
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logs a deprecation banner during config validation when a run selects the Linen code path, and notes the upcoming deprecation in the relevant field descriptions.
What it looks like
Testing
Selected by:enable_nnx=falseenable_nnx=Falsepure_nnx=falsepure_nnx=Falsepure_nnx_decoder=falsepure_nnx_decoder=FalseChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.