Exclude optimizer state when running to_huggingface - #4650
Open
hengtaoguo wants to merge 1 commit into
Open
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hengtaoguo
marked this pull request as ready for review
July 28, 2026 21:59
hengtaoguo
requested review from
RissyRan,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
igorts-git,
jiangjy1982,
parambole,
richjames0,
shralex,
shuningjin and
suexu1025
as code owners
July 28, 2026 21:59
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
YixuanWang-99
approved these changes
Jul 28, 2026
SurbhiJainUSC
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
load_orbax_checkpoint(only used by to_huggingface conversion).opt_statefor Linen,optimizerfor NNX).Result: Peak memory cut down in half for llama3.1-8b: 123.64 GB -> 62.60 GB
Fixes: b/538004926
Tests
roundtrip_conversion test still passes.
I generated train checkpoint using:
Checkpoint conversion for to_huggingface (downloaded gcs ckpt to local dir for faster debugging):
Before the fix:
After the fix:
After conversion, validated the correctness
Forward pass logits checker against itself
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.