Conversation
RissyRan
requested review from
bvandermoon,
darisoy,
gobbleturk,
huytransformer,
igorts-git,
khatwanimohit,
parambole,
richjames0,
shralex and
xibinliu
as code owners
July 28, 2026 17:32
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This Pull Request increases the maxSessionTurns parameter from 25 to 100 within the settings of the Gemini workflows (gemini_invoke.yml and gemini_review.yml). This adjustment is highly beneficial for longer interactive assistant sessions and comprehensive pull request reviews, ensuring the agent does not run out of session turns prematurely.
🔍 General Feedback
- Consistency across workflows: The change is highly consistent with the existing
gemini_investigate.ymlworkflow, which already specifiesmaxSessionTurns: 100. - Improved developer experience: Increasing the session turn limit allows the Gemini CLI agent to successfully complete more complex, multi-step code generation and debugging tasks without failing due to turn constraints.
- Syntactic Correctness: The JSON and YAML syntax within both modified workflow files is completely valid and properly formatted.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
entrpn
approved these changes
Jul 28, 2026
NuojCheng
approved these changes
Jul 28, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Jul 28, 2026
- Sink jnp.dynamic-slice instructions fetching blocks of q, k and v into the inner loop. - Forced final @v layout for better utilization - Forcing fusions with must_fuse_call - Removed calculations related to mask blocking when the mask is causal FUTURE_COPYBARA_INTEGRATE_REVIEW=#4648 from AI-Hypercomputer:max_turn e10b8ea PiperOrigin-RevId: 952800018
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We frequently met this max session turn limitation. Increase the
maxSessionTurnsfrom 25 to 100, and this is also aligns with Gemini investigation task.Tests
Expected checks are all green.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.