Add Simple-evals supports to maxtext runner - #4644
Open
JamesDeng42 wants to merge 2 commits into
Open
Conversation
JamesDeng42
requested review from
dipannita08,
hengtaoguo and
igorts-git
as code owners
July 28, 2026 16:29
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
JamesDeng42
force-pushed
the
yujideng/simple_evals
branch
3 times, most recently
from
July 28, 2026 18:55
1270fdf to
eec8114
Compare
JamesDeng42
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
gagika,
gobbleturk,
huytransformer,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025,
vipannalla and
xibinliu
as code owners
July 28, 2026 18:55
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
JamesDeng42
force-pushed
the
yujideng/simple_evals
branch
from
July 28, 2026 20:31
eec8114 to
c5f3e34
Compare
vlad-karp
reviewed
Jul 28, 2026
| "max_tokens": max_tokens, | ||
| "temperature": temperature, | ||
| } | ||
| async with semaphore: |
Collaborator
There was a problem hiding this comment.
why did you remove this?
Collaborator
Author
There was a problem hiding this comment.
i do not remove this, i move it into the loop in line 107. it is still semaphore bounded but the slot is released before retry backoff.
Contributor
|
🤖 Hi @entrpn, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Contributor
|
🤖 I'm sorry @entrpn, but I was unable to process your request. Please see the logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is an extension of vLLM Eval Framework. It added simple_evals runner to support gpt-oss model family.
Tests
Added dedicated unit tests.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.