Skip to content

Bugfix #218 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maiyishan wants to merge 2 commits into
base: vnbdev
Choose a base branch
from
Open

Bugfix #218 #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41aced1
Bug fix for issue #218
maiyishan Aug 20, 2026
f854e00
Attempt to fix pytest failure
maiyishan Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

## Recent Version Update

**✨ DABEST “Bingka” v2025.10.20 for Python is now released! ✨**
**✨ DABEST "Bingka" v2025.10.20 for Python is now released! ✨**

Dear DABEST users,
The latest version of the DABEST Python library brings new visualizations, refined plots, and improved accuracy.
Expand All @@ -20,7 +20,7 @@ The latest version of the DABEST Python library brings new visualizations, refin

Introducing **Whorlmap**, a new way to visualize effect sizes from multiple comparisons in a compact, grid-based format.

Whorlmaps condense information from the full bootstrap distributions of many contrast objects into a **2D heatmap-style grid of “whorled” cells**. This provides an overview of the entire dataset while preserving the underlying distributional detail.
Whorlmaps condense information from the full bootstrap distributions of many contrast objects into a **2D heatmap-style grid of "whorled" cells**. This provides an overview of the entire dataset while preserving the underlying distributional detail.

They are especially useful for large-scale or multi-condition experiments, serving as a **space-efficient alternative to stacked forest plots**.

Expand Down
15 changes: 13 additions & 2 deletions dabest/misc_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,7 @@ def get_color_palette(

# Create color palette that will be shared across subplots.
color_col = plot_kwargs["color_col"]

if color_col is None:
color_groups = pd.unique(plot_data[xvar])
bootstraps_color_by_group = True
Expand All @@ -556,12 +557,22 @@ def get_color_palette(
bootstraps_color_by_group = False
if show_pairs:
if plot_kwargs["custom_palette"] is not None:
if delta2 or sankey:
if delta2:
bootstraps_color_by_group = False
elif sankey:
bootstraps_color_by_group = False
else:
bootstraps_color_by_group = True
if color_col is None:
color_groups = pd.unique(plot_data[xvar])
bootstraps_color_by_group = True
else:
if color_col not in plot_data.columns:
raise KeyError("``{}`` is not a column in the data.".format(color_col))
color_groups = pd.unique(plot_data[color_col])
bootstraps_color_by_group = False
else:
bootstraps_color_by_group = False


# Handle the color palette.
filled = True
Expand Down
15 changes: 13 additions & 2 deletions nbs/API/misc_tools.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@
"\n",
" # Create color palette that will be shared across subplots.\n",
" color_col = plot_kwargs[\"color_col\"]\n",
"\n",
" if color_col is None:\n",
" color_groups = pd.unique(plot_data[xvar])\n",
" bootstraps_color_by_group = True\n",
Expand All @@ -607,12 +608,22 @@
" bootstraps_color_by_group = False\n",
" if show_pairs:\n",
" if plot_kwargs[\"custom_palette\"] is not None:\n",
" if delta2 or sankey:\n",
" if delta2:\n",
" bootstraps_color_by_group = False\n",
" elif sankey:\n",
" bootstraps_color_by_group = False\n",
" else:\n",
" bootstraps_color_by_group = True\n",
" if color_col is None:\n",
" color_groups = pd.unique(plot_data[xvar])\n",
" bootstraps_color_by_group = True\n",
" else:\n",
" if color_col not in plot_data.columns:\n",
" raise KeyError(\"``{}`` is not a column in the data.\".format(color_col))\n",
" color_groups = pd.unique(plot_data[color_col])\n",
" bootstraps_color_by_group = False \n",
" else:\n",
" bootstraps_color_by_group = False\n",
" \n",
"\n",
" # Handle the color palette.\n",
" filled = True\n",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ dev = ['pytest~=8.3.4', 'pytest-mpl~=0.17.0']
version = {attr = "dabest.__version__"}

[tool.setuptools.packages.find]
include = ["dabest"]
include = ["dabest", "dabest.*"]

[tool.nbdev]
branch = 'master'
Expand Down
Loading