Repository navigation
Add message requests for direct messages from non-friends - #739
Merged
Merged
Conversation
Players can message anyone who takes message requests, not only friends. A first message from a non-friend waits under a Requests button on the chat rail instead of opening a tab, badging or flashing. Opening one shows the conversation with a banner; replying accepts it and Deny hides it. The sender's composer stays locked with a hint until they get a reply. Message buttons now show for non-friends, except on the profile of a player who has turned requests off. The setting lives on the blocked players page.
The spy returned one shared Response, so when apollo reached fetch first it consumed the body and the image fetch failed, leaving the editor closed. Whether apollo got there first depended on test order.
Players in the Others tab get a Message button. Its tooltip explains that a first message to a non-friend is a request they reply to accept. It is disabled for players who only take messages from friends, and the row says Waiting for a reply once a request is out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes with 5stackgg/api#516.