bug: tournaments index grows a section at a time while it loads - #589
Merged
Merged
Conversation
The curated view had four independent sources -- two subscriptions and two RecentTournaments fetches -- each revealing itself as it reported in, so the page changed height four times on the way up. Gates all of them behind one reveal, with a 2.5s deadline so a websocket that is slow or never connects cannot hold the page back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curated view is fed by four independent sources — the live and registration-open subscriptions, and the two
RecentTournamentsfetches — and each revealed itself as it reported in. The page changed height four times on the way up.Gates all of them behind a single
curatedReady, so everything lands on one tick.Two things that made the naive version of this worse rather than better:
RecentTournamentsonly fetches once mounted, and it's one of the things being waited on. The sections stay mounted behind the skeleton, clipped to zero height rather thandisplay:none, so their banners are decoded before they're shown.inertandaria-hiddenkeep the hidden copy out of reach of the keyboard and screen readers.Skeletons now carry
TournamentFeatureCard's exact height and radius — a wrong-sized skeleton just moves the jump from "content appears" to "content resizes".Also folds the drilldown's three states into one
PageTransitionwithswap, so re-filtering cross-fades in place instead of the outgoing list sliding up past the incoming one, and moves the leftover Options API block into the existing<script setup>(the subscriptions becomeuseSubscription, paused while a filter is active).Tests pass (111). The prettier warning on this file is pre-existing on main and left alone.