bug: queue player counts, friend button state, highlight self filter, name change notifications - #577
Merged
Merged
Conversation
… name change notifications - the matchmaking queue count counted lobbies, so a queued trio showed as 1 - the profile friend badge matched any my_friends row, so a pending request already read as "Friend"; the hero now shows add / requested / accept / friend - highlights could not be filtered to your own clips - name change notifications rendered their body as plain text, showing the escaped entities, and had no link to the player - the team owner can no longer leave their own team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web half of the fork-triage bug fixes. The queue count needs 5stackgg/api#409 to ship with it; the rest stand alone.
isFriendmatched anymy_friendsrow, including a still-pending one, so the hero showed the green "Friend" badge right after you sent a request — and again when someone sent you one. It now goes throughuseFriendActions: add / requested / accept / friend, with the in-flight state the rest of the app already uses.'. It renders like every other type now (sanitized), and the notification shows the player card, so it links to the profile.Tests: 98.