Skip to content

Spanish instrumentation testing - #322

Open
brianjcoan wants to merge 6 commits into
5calls:mainfrom
brianjcoan:spanish_testing
Open

Spanish instrumentation testing#322
brianjcoan wants to merge 6 commits into
5calls:mainfrom
brianjcoan:spanish_testing

Conversation

@brianjcoan

Copy link
Copy Markdown
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization

Description

Enable running the instrumentation tests in Spanish, either by explicitly setting the app locale via CLI argument,
or simply running the emulator/device with a Spanish system-wide locale setting and the test detects same.
Created a BaseIntegrationTest that all tests inherit, both for this locale work but also pulling out setup and
methods that are generally useful.

Related Issues

  • Related Issue #
  • Closes #

Were the changes tested?

  • Yes, automated tests in ALL
  • Yes, manually tested: please provide steps performed to test changes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Tests:

  1. Emulator in US English locale, ./gradlew :app:connectedAndroidTest
  2. Emulator in US Spanish locale, ./gradlew :app:connectedAndroidTest
  3. Emulator system locale irrelevant, ./gradlew :app:connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.locale=en-US
  4. Emulator system locale irrelevant,./gradlew :app:connectedAndroidTest -Pandroid.testInstrumentationRunnerArguments.locale=es-US

N.B. run as a batch, instrumentation tests can still be flaky, but individually are all green

@dektar

dektar commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Could you explain the value of having integration testing in Spanish? As long as we keep the strings in strings.xml, I trust Android to swap in the right language when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants