Upgraded gradle version, fixed what deprecated gradle settings could be fixed - #318
Upgraded gradle version, fixed what deprecated gradle settings could be fixed#318brianjcoan wants to merge 3 commits into
Conversation
I believe Graphview is used in the stats activity to show historical calls. Does this change break that graph? |
| testOptions { | ||
| unitTests { | ||
| includeAndroidResources = true | ||
| returnDefaultValues = true |
There was a problem hiding this comment.
this doesn't seem related to the commit message about updating the gradle version. maybe do separately?
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.7.1-bin.zip | ||
| networkTimeout=10000 | ||
| validateDistributionUrl=true |
There was a problem hiding this comment.
I used the Android Studio gradle upgrade tool, it made these changes.
validateDistributionUrl is a Gradle Wrapper property and task configuration that checks if the specified Gradle distribution URL is valid and reachable before writing it to the properties file.
The networkTimeout property specifies how many milliseconds Gradle will wait during network operations before timing out. It primarily controls the limit when downloading the Gradle wrapper JAR and distribution ZIP files.
Both of the values are the defaults, so I'm guessing not really necessary,
probably the tool bringing one's attention to the new properties.
This PR change doesn't break this, my comment is that I did NOT get rid of the |
2 participants
What type of PR is this? (check all applicable)
Description
Gradle was out of date, and reporting deprecated methods, see attached.
Still reports one deprecation issue:
WARNING: The option setting 'android.enableJetifier=true' is deprecated. The current default is 'false'. It will be removed in version 10.0 of the Android Gradle plugin.However can't fix this one because
The following libraries used by project ':app' depend on legacy support libraries. To disable Jetifier, you will need to use AndroidX-supported versions of these libraries. com.jjoe64:graphview:4.2.2 (Project ':app', configuration 'debugAndroidTestCompileClasspath' -> com.jjoe64:graphview:4.2.2 -> com.android.support:support-v4:27.1.1)Related Issues
Were the changes tested?
have not been included
5Calls_gradle.txt