Repository navigation
Release candidate - #27
Merged
Merged
Conversation
device-detection-dotnet-examples has moved into 51degrees-dotnet, under examples/device-detection. Both dotnet demos, pmp-web and GettingStarted-Web, are found there as siblings, and the docs name the monorepo.
* Find the Node example in 51degrees-node * Copy the monorepo packages in when installing the Node example
* Let Java use the default JSON endpoint and still accept its old one * Say once which JSON path each language uses
…d ones (#25) * Test that the .NET example is given the underscore variable names The .NET cloud web example reads the resource key from _51DEGREES_RESOURCE_KEY and the cloud endpoint from _51DEGREES_CLOUD_ENDPOINT, with no other name, once its rename is released. * Give the .NET example the _51DEGREES_ variable names The .NET cloud web example now reads the resource key from _51DEGREES_RESOURCE_KEY and the endpoint from _51DEGREES_CLOUD_ENDPOINT, with no other name. Released versions of it read SUPER_RESOURCE_KEY and FIFTYONE_CLOUD_ENDPOINT, so the harness sets both pairs until every language has released with the new names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in
One change since the last release, #24, which merged
rcintomainat 16:38 UTC on 10 November 2026._51DEGREES_RESOURCE_KEYand_51DEGREES_CLOUD_ENDPOINTas well asSUPER_RESOURCE_KEYandFIFTYONE_CLOUD_ENDPOINT, andDescriptors_Dotnet_SetsTheUnderscoreNameschecks the new names.Comparing the two trees,
mainandrcdiffer only inExamples/ExampleApps.cs(5 lines added) andExamples/ExampleAppsTests.cs(20 lines added), which are #25's.GitHub's comparison lists nine commits ahead of
mainand five files, because it comparesrcwith the point the two branches last shared. #23, "Java uses the default JSON endpoint and still accepts the old one", is among them, but it is already inmain. #24 was merged as one squashed commit, 389d51b, which changes exactly #23's four files,BrowserCache/SessionStorageCacheTests.cs,Examples/ExampleApps.cs,Examples/ExampleDescriptor.csandTestsCommon/Helpers/TestHelpers.cs, andmainandrcnow hold the same text in the three of those that #25 does not touch. So #23 shipped in #24, and this release adds #25 alone.Why now
51degrees-dotnet#131 makes the .NET example read only the
_51DEGREES_names, and the cloud service's own tests start that example through this harness frommain. So this release has to merge before 51degrees-dotnet#131 does, or those tests start the example with no resource key and no endpoint.Build
Run 43041958233, on head c7ca30f, passed.
build-and-testran 40 tests with 15 skipped, being the tests that need a browser, the cloud or keys, which that job leaves out, and the browser job passed on ubuntu-latest, ubuntu-22.04-arm and ubuntu-24.04-arm. TheOnly rc into maincheck passed. This repository builds no macOS entries.What remains
#26 tracks taking the old names out once every language has released with the
_51DEGREES_names.Version
This repository is not published as a package. No version change.