Repository navigation
Check that only rc merges into the default branch - #19
Merged
Merged
Conversation
jwrosewell
marked this pull request as ready for review
November 3, 2026 18:43
Merged
jwrosewell
added a commit
that referenced
this pull request
Nov 4, 2026
* Find the Java example in 51degrees-java (#16) * Find the dotnet example in 51degrees-dotnet (#17) device-detection-dotnet-examples has moved into 51degrees-dotnet, under examples/device-detection. Both dotnet demos, pmp-web and GettingStarted-Web, are found there as siblings, and the docs name the monorepo. * Find the Node example in 51degrees-node (#18) * Find the Node example in 51degrees-node * Copy the monorepo packages in when installing the Node example * Check that only rc merges into the default branch (#19) * Find the Python example in 51degrees-python (#20) * Find the PHP example in 51degrees-php (#21) --------- Co-authored-by: ben51degrees <ben@51degrees.com> Co-authored-by: Jamesr51d <122470673+Jamesr51d@users.noreply.github.com> Co-authored-by: Eugene Dorfman <justadreamer2007@gmail.com>
Merged
jwrosewell
added a commit
that referenced
this pull request
Nov 10, 2026
* Find the Java example in 51degrees-java (#16) * Find the dotnet example in 51degrees-dotnet (#17) device-detection-dotnet-examples has moved into 51degrees-dotnet, under examples/device-detection. Both dotnet demos, pmp-web and GettingStarted-Web, are found there as siblings, and the docs name the monorepo. * Find the Node example in 51degrees-node (#18) * Find the Node example in 51degrees-node * Copy the monorepo packages in when installing the Node example * Check that only rc merges into the default branch (#19) * Find the Python example in 51degrees-python (#20) * Find the PHP example in 51degrees-php (#21) * Java uses the default JSON endpoint and still accepts the old one (#23) * Let Java use the default JSON endpoint and still accept its old one * Say once which JSON path each language uses --------- Co-authored-by: ben51degrees <ben@51degrees.com> Co-authored-by: Jamesr51d <122470673+Jamesr51d@users.noreply.github.com> Co-authored-by: Eugene Dorfman <justadreamer2007@gmail.com>
jwrosewell
added a commit
that referenced
this pull request
Nov 11, 2026
* Find the Java example in 51degrees-java (#16) * Find the dotnet example in 51degrees-dotnet (#17) device-detection-dotnet-examples has moved into 51degrees-dotnet, under examples/device-detection. Both dotnet demos, pmp-web and GettingStarted-Web, are found there as siblings, and the docs name the monorepo. * Find the Node example in 51degrees-node (#18) * Find the Node example in 51degrees-node * Copy the monorepo packages in when installing the Node example * Check that only rc merges into the default branch (#19) * Find the Python example in 51degrees-python (#20) * Find the PHP example in 51degrees-php (#21) * Java uses the default JSON endpoint and still accepts the old one (#23) * Let Java use the default JSON endpoint and still accept its old one * Say once which JSON path each language uses * Give the .NET example the _51DEGREES_ variable names alongside the old ones (#25) * Test that the .NET example is given the underscore variable names The .NET cloud web example reads the resource key from _51DEGREES_RESOURCE_KEY and the cloud endpoint from _51DEGREES_CLOUD_ENDPOINT, with no other name, once its rename is released. * Give the .NET example the _51DEGREES_ variable names The .NET cloud web example now reads the resource key from _51DEGREES_RESOURCE_KEY and the endpoint from _51DEGREES_CLOUD_ENDPOINT, with no other name. Released versions of it read SUPER_RESOURCE_KEY and FIFTYONE_CLOUD_ENDPOINT, so the harness sets both pairs until every language has released with the new names. --------- Co-authored-by: ben51degrees <ben@51degrees.com> Co-authored-by: Jamesr51d <122470673+Jamesr51d@users.noreply.github.com> Co-authored-by: Eugene Dorfman <justadreamer2007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the check that only
rcmerges into this repository's default branch. It calls common-ci's shared workflow (common-ci#294) on every pull request. A pull request into the default branch fails unless its head is this repository'src, and any other pull request passes.The check is "Only rc into main / check", the same in every 51Degrees public repository, so one organisation ruleset can require it on each default branch.
It uses the workflow from common-ci's
main, so it cannot start until common-ci#294 has reached common-ci'smain. Until then this pull request's own check fails to start, which is expected. Merge it intorcafter that.