Repository navigation
Say when to use each performance profile, and what HighPerformance holds - #308
Draft
jwrosewell wants to merge 1 commit into
Draft
jwrosewell wants to merge 1 commit into
jwrosewell wants to merge 1 commit into
Conversation
The performance options page now has a Choosing a profile section that says when to use MaxPerformance, HighPerformance, Balanced and LowMemory, and an IP Intelligence profiles section with measured memory and lookup times for HighPerformance and Balanced against the Enterprise file. HighPerformance now loads only what the named properties read, and IP Intelligence Balanced holds the same whatever is named, so the pages that said HighPerformance uses about as much memory as MaxPerformance, and that naming properties changes what Balanced holds, now say what the library does. The link to the profile definitions points at the current code for both engines rather than an old commit. These describe the C library's next release, so this merges after the pull request it is stacked on and after that release and the language releases that carry it.
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The performance options page listed the profiles but gave little help in choosing one, and called HighPerformance "generally not recommended, because it uses about as much memory as MaxPerformance". The C library's next release changes what HighPerformance and IP Intelligence Balanced hold:
loadRequiredPropertiesOnly), and Balanced holds the same whatever is named.Change
src/devicedetection/features/performanceoptions.mdsrc/devicedetection/cloudtoonpremise.md: the HighPerformance line no longer says it uses about as much memory as MaxPerformance, and links to the guidance.src/ipintelligence/algorithm.md: naming required properties is described under HighPerformance, not Balanced.src/productsummaries/hardwarebenchmarks.md: the same correction to the paragraph that described Balanced from version 4.5.98.Sources checked
hash.clines 307 to 401,ipi.clines 192 to 290,ipi.hlines 455 to 505).Not covered
reuseTempFileis false for Device Detection and true for IP Intelligence). The profile setters in the C++ layer don't copy the temp file setting, so outside Go it behaves as Balanced. That needs a decision before it is documented.Merge order