Repository navigation
Leave evidence named licence out of a cloud request - #86
Closed
jwrosewell wants to merge 2 commits into
Closed
jwrosewell wants to merge 2 commits into
jwrosewell wants to merge 2 commits into
Conversation
The service reads licence as another spelling of license, so evidence that strips to either is left out, in any letter case.
Contributor
Author
|
Closing as superseded by #79, which merged into rc on 10 November and already leaves Evidence named licence out of a cloud request, by holding licence in RESERVED_EVIDENCE_SUFFIXES in constants.py. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For specifications#125. Evidence whose key strips to
values,resource,licenseorlicence, in any letter case, MUST be left out of the request, because the remote server also readslicenceas another spelling oflicense. Python compared the stripped name, lower-cased, withresource,licenseandvaluesonly, so evidence namedlicencewas sent beside the engine's own licence key.What changed
RESERVED_EVIDENCE_SUFFIXESinpipeline/fiftyone_pipeline_cloudrequestengine/src/fiftyone_pipeline_cloudrequestengine/constants.pyincludeslicence. The comparison already ignored letter case.How it was verified
New test
test_reserved_evidence.py.95966788: LICGREENThe last release into
mainmerged on 2026-11-04.