Repository navigation
Say in AGENTS.md that a test failing on timing is fixed - #115
Draft
jwrosewell wants to merge 1 commit into
Draft
jwrosewell wants to merge 1 commit into
jwrosewell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tests that fail on a time limit, a performance threshold or a timeout, and pass when run again, keep coming back at random, and each time someone has to look into the failure before running it again.
AGENTS.mdsays nothing about them, so a contributor who meets one runs it again.What changed
AGENTS.mdgains a short section, "Tests that fail on timing", which says such a test is fixed, either with a limit that fits the slowest runner it runs on, with each runner's measurement behind it, or by finding and fixing why it takes too long. Nothing else changes.Checks
This changes documentation only and no package code, so it merges on its quick checks and a review, without a full build. It waited for the release #114, which merged into
mainat 06:22 UTC on 13 November, so it can merge now.