Repository navigation
Point configuration page links at 51degrees.com/configure - #107
Draft
jwrosewell wants to merge 2 commits into
Draft
jwrosewell wants to merge 2 commits into
jwrosewell wants to merge 2 commits into
Conversation
The Cloud Configurator has moved from configure.51degrees.com to https://51degrees.com/configure. Links and mentions shown to people (READMEs, comments, example output and messages) now use the new address, keeping each link's key or sharing code and its query.
On the lines that carry the 51degrees.com/configure address, the text people read now says "configuration page". Code identifiers, file names and settings keys are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, do not merge yet
This pull request must stay a draft until https://51degrees.com/configure answers. The old address still works today, so nothing is broken while this waits.
What changed and why
The configuration page has moved from
configure.51degrees.comto https://51degrees.com/configure. The links and mentions that people read (READMEs, code comments, example output, and the messages that tell someone where to create a Resource Key) now use the new address.https://configure.51degrees.com/<code>?<query>becamehttps://51degrees.com/configure/<code>?<query>, with each key, sharing code, path, trailing slash and query kept exactly as written.rcshows 52 additions and 52 deletions in 37 files, over 2 commits).The occurrences in code are constants and strings that are only written into messages telling a person where to create a Resource Key (the cloud request engine's error messages, the examples' output, and the test helpers that explain a missing key).
Files and line counts
AGENTS.mdREADME.mddevice-detection/fiftyone_devicedetection_cloud/readme.mddevice-detection/fiftyone_devicedetection_cloud/tests/live_cloud.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/configurator_console.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/failuretomatch.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/gettingstarted_console.jsondevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/gettingstarted_console.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/gettingstarted_web/app.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/metadata_console.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/nativemodellookup_console.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/taclookup_console.jsondevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/taclookup_console.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/useragentclienthints_web/app.pydevice-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/example_utils.pydevice-detection/fiftyone_devicedetection_examples/tests/live_cloud.pydevice-detection/readme.mdip-intelligence/fiftyone_ipintelligence_cloud/readme.mdip-intelligence/fiftyone_ipintelligence_examples/readme.mdip-intelligence/fiftyone_ipintelligence_examples/src/fiftyone_ipintelligence_examples/cloud/getallproperties_console.pyip-intelligence/fiftyone_ipintelligence_examples/src/fiftyone_ipintelligence_examples/cloud/gettingstarted_console.pyip-intelligence/fiftyone_ipintelligence_examples/src/fiftyone_ipintelligence_examples/cloud/gettingstarted_web/app.pyip-intelligence/fiftyone_ipintelligence_examples/src/fiftyone_ipintelligence_examples/cloud/metadata_console.pyip-intelligence/fiftyone_ipintelligence_examples/src/fiftyone_ipintelligence_examples/cloud/mixed_console.pyip-intelligence/fiftyone_ipintelligence_examples/tests/live_cloud.pylocation/examples/cloud/gettingstarted.pylocation/examples/cloud/web.pylocation/readme.mdpipeline/fiftyone_pipeline_cloudrequestengine/examples/readme.mdpipeline/fiftyone_pipeline_cloudrequestengine/examples/src/fiftyone_pipeline_examples/cloud/mixed/gettingstarted_console.pypipeline/fiftyone_pipeline_cloudrequestengine/examples/src/fiftyone_pipeline_examples/cloud/mixed/gettingstarted_web/app.pypipeline/fiftyone_pipeline_cloudrequestengine/examples/src/fiftyone_pipeline_examples/cloud/mixed/pipeline.pypipeline/fiftyone_pipeline_cloudrequestengine/examples/tests/live_cloud.pypipeline/fiftyone_pipeline_cloudrequestengine/readme.mdpipeline/fiftyone_pipeline_cloudrequestengine/src/fiftyone_pipeline_cloudrequestengine/constants.pypipeline/fiftyone_pipeline_cloudrequestengine/tests/test_cloudengine.pypipeline/fiftyone_pipeline_did/tests/live_cloud.pyWording
On the lines that carry the address, the text people read now calls the place the "configuration page". Code identifiers, file and folder names, settings keys and documentation page addresses are unchanged. Other lines that use the old name were left for a separate sweep.
Each changed sentence
AGENTS.mdline 208: "configuration page."device-detection/fiftyone_devicedetection_cloud/readme.mdline 15: "* Create a resource key for free with the 51Degrees configuration page. This defines the properties yo"device-detection/fiftyone_devicedetection_examples/src/fiftyone_devicedetection_examples/cloud/configurator_console.pyline 28: "# This example is displayed at the end of the configuration page"device-detection/readme.mdline 39: "configuration page, see our"ip-intelligence/fiftyone_ipintelligence_cloud/readme.mdline 14: "from the 51Degrees configuration page."ip-intelligence/fiftyone_ipintelligence_examples/readme.mdline 14: "Obtain one from the 51Degrees configuration page."location/readme.mdline 26: "* Create a resource key for free with the 51Degrees configuration page. This defines the properties yo"pipeline/fiftyone_pipeline_cloudrequestengine/examples/readme.mdline 34: "configuration page,"Base branch
rc, because recent changes to this repository were merged intorc(for example #104 and #103) and reachmainin a release pull request.Campaign tags
No campaign tag was added, removed or changed. The shared campaign tag lint (
scripts/utm-lint.ps1in common-ci) applies the same rules toconfigure.51degrees.comand51degrees.com, so every link that was tagged keeps its five parameters and every link that was untagged was in a file the lint does not check (test folders) and stays untagged.What was left alone
Nothing. No occurrence of the old address remains on this branch.
How it was checked
rcforconfigure.51degrees.com, ignoring case, found 52 lines in 37 files. The same search on this branch finds none.Before marking ready