Skip to content

Give the specification's JSON Builder error text with no sequence number #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwrosewell merged 2 commits into from
Nov 11, 2026
Merged

Give the specification's JSON Builder error text with no sequence number #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877fed7
Test the exact JSON Builder error text with no sequence number
jwrosewell Nov 11, 2026
2a049c5
Give the specification's JSON Builder error text with no sequence number
jwrosewell Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pipeline/fiftyone_pipeline_core/src/fiftyone_pipeline_core/jsonbundler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,8 @@ def process_internal(self, flowdata):
sequence = flowdata.evidence.get("query.sequence")
if isinstance(sequence, bool) or not isinstance(sequence, int):
raise Exception(
"The JSON Builder needs the sequence number that a Sequence "
"Element produces. A Sequence Element needs to be placed "
"before it in the Pipeline.")
"The JSON Builder needs a sequence number. Place a Sequence "
"Element before the JSON Builder in the Pipeline.")

# Get every property on every FlowElement
# Storing JavaScript properties in an extra section
Expand Down
5 changes: 4 additions & 1 deletion pipeline/fiftyone_pipeline_core/tests/test_jsonbundler_sequence_required.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ def test_no_sequence_number_is_an_error_that_names_the_sequence_element(
flowdata = pipeline.create_flowdata()
with self.assertRaises(Exception) as caught:
flowdata.process()
self.assertIn("Sequence Element", str(caught.exception))
self.assertEqual(
"The JSON Builder needs a sequence number. Place a Sequence "
"Element before the JSON Builder in the Pipeline.",
str(caught.exception))

def test_no_json_is_set_when_the_error_is_suppressed(self):
pipeline = bundler_only(suppress=True)
Expand Down
Loading