[jwrosewell]

The cloud request engine and the 51Did client read their endpoint from _51DEGREES_CLOUD_ENDPOINT in place of FOD_CLOUD_API_URL, with no fallback, for consistency with the other languages in the 11 November release. The environment variable name check now rejects the old name anywhere in the repository.

The problem

Node read the endpoint from FOD_CLOUD_API_URL in two places, the cloud request engine (cloudRequestEngine.js line 143 at 8093efa) and the 51Did client (didClient.js line 1009). The CI script set it for the cloud contract tests (ci/run-integration-tests.ps1 line 88), and four IP Intelligence examples, the creator context web example, two readmes, the 51Did type declarations and two integration tests named it.

Rust reads _51DEGREES_CLOUD_ENDPOINT (README.md line 419 at 245bc39), and the drafts 51degrees-dotnet#131, 51degrees-java#105, 51degrees-python#100, 51degrees-php#68 and 51degrees-go#102 make the same rename. .NET's draft takes FOD_CLOUD_API_URL and FIFTYONE_CLOUD_ENDPOINT to _51DEGREES_CLOUD_ENDPOINT under the decision it quotes, "Just use the version that works everywhere all the time with no fallback."

What changed

• cloudRequestEngine.js and didClient.js read process.env._51DEGREES_CLOUD_ENDPOINT. Nothing reads the old name. The baseURL and endpoint options still win over the variable, and the public cloud is still the default.
• The examples, both readmes, types/didClient.d.ts, the two 51Did integration tests and ci/run-integration-tests.ps1 name the new variable. Two comments, one readme paragraph and one error message that the longer name pushed past 80 columns are rewrapped.
• ci/tests/environmentVariableNames.test.js gains OLD_NAME, which matches the whole old name in any letter case wherever it appears, read, set or in prose, and leaves a longer name holding it alone. The test "names no old cloud endpoint variable" runs it over every tracked file, and "matches only the whole old cloud endpoint name" checks what it matches.

Tests, red then green

New and changed tests:

• cloudRequestEngine.test.js sets _51DEGREES_CLOUD_ENDPOINT in the two endpoint precedence tests, and the new "custom end point - old variable name not read" sets only the old name and expects the default.
• didClient.test.js uses the new name throughout, and the new "endpoint does not read the old variable name" does the same for the 51Did client.
• The two guard tests above.

The tests in cloudRequestEngine.test.js and didClient.test.js that name the old name build it in two parts, 'FOD' + '_CLOUD_API_URL', so the guard does not find it in them. The guard file itself does not do that. ci/tests/environmentVariableNames.test.js carries the old name as a literal nine times, once in OLD_NAME and eight times in its own test of what OLD_NAME matches, and the scan passes over it only because that file is the one entry in SKIPPED_FILES (lines 63 to 66 at 80a1bf7), which namesInRepository leaves out of every scan (line 120). So a name added to the guard's own tests is not found by the guard, and a name added anywhere else is.

The red and green runs used a temporary workflow on throwaway branches, since deleted, which ran these three test files with Jest.

• Red, on 48be361 (the tests alone): https://github.com/51Degrees/51degrees-node/actions/runs/43085397694. Six of 141 fail, being "environment variable names › names no old cloud endpoint variable", "custom end point - environment precedence", "custom end point - old variable name not read", "DidClient construction › endpoint reads _51DEGREES_CLOUD_ENDPOINT and normalises the slash", "DidClient construction › endpoint does not read the old variable name" and "DidClient without a resource key › is built with the endpoint alone".
• Green, on 0948eb3 (the tests and the change): https://github.com/51Degrees/51degrees-node/actions/runs/43085418269. All 141 pass.

Full build

The head is 80a1bf7, which merges rc at f76d8b0 into 0948eb3. rc had taken #45 since this draft was opened, which also changes cloudRequestEngine.js and cloudRequestEngine.test.js, and the merge was clean. The red and green above are of 0948eb3, and the merge changes no line this draft changes.

• https://github.com/51Degrees/51degrees-node/actions/runs/43085458618 passed on 0948eb3, the head before the merge.
• https://github.com/51Degrees/51degrees-node/actions/runs/43097282005, started on 80a1bf7 during the GitHub Actions outage of 11 November, never started, so it is not cited for a result.
• https://github.com/51Degrees/51degrees-node/actions/runs/43111874333 on 80a1bf7 failed on Ubuntu ARM with Node 24, 1 of 1227, and the other jobs were cancelled. The failing test is shareUsageBackOff.test.js "share usage back-off - full queue drops new evidence", which sent four of the six entries it expects to be dropped. This draft changes no usage sharing file, and the same test passed on both Ubuntu ARM jobs of #75's full build on the same rc. The test expects ten processes to finish inside a two second pause, so a slow runner can end the pause early. The test needs a change of its own, which this draft does not make.
• https://github.com/51Degrees/51degrees-node/actions/runs/43113889046 passed on the head, 80a1bf7. Its seven Setting 'PullRequestSha' lines all name 80a1bf7, Configure printed "Left out 2 macOS entries", and Build and Test passed with Node 22 and 24 on Ubuntu, Ubuntu ARM and Windows. On each of the six, the unit tests gave 1,225 passed and 2 skipped, the integration tests, which ci/run-integration-tests.ps1 runs with the renamed variable, gave 132 passed and 4 skipped, and environmentVariableNames.test.js, cloudRequestEngine.test.js and didClient.test.js all passed.

macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.

Release note

• The cloud request engine and the 51Did client read their endpoint from _51DEGREES_CLOUD_ENDPOINT in place of FOD_CLOUD_API_URL. The old name is no longer read, so set the new one.

What remains

Nothing in this repository. The same rename in the other languages is in the drafts listed above.

[jwrosewell]

Closing and reopening at once to start the checks again, because the runs queued during GitHub's Actions outage this evening never started.