Repository navigation
Give the specification's JSON Builder error text with no sequence number - #74
Merged
Merged
Conversation
Every language gives the same text when no Sequence Element has produced a sequence number, as the JSON Builder page of the specification states.
This was referenced Nov 11, 2026
Merged
Merged
Merged
jwrosewell
marked this pull request as ready for review
November 11, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
James Rosewell's rule for the 11 November 2026 release is "The point of the release is consistency." When no Sequence Element has produced a sequence number, the JSON Builder fails with an error, and each language that has the error gave it its own wording. Node said "There is no sequence number. A Sequence Element needs to be placed before the JSON Builder Element in the Pipeline." (
pipeline/fiftyone.pipeline.core/jsonbundler.jslines 73 and 74 onrc).What the specification says
specifications#139, merged into rc as d72eb074, gives the exact text.
json-builder.mdat d72eb074, lines 120 to 142:What changed
Two commits, the test first (f654ea0) and then the message (a7bb064). Nothing else changes.
pipeline/fiftyone.pipeline.core/jsonbundler.jslines 73 and 74,getSequencereads the sequence from the Sequence Element's data, or fromquery.sequencewhen there is no such data, and throws anErrorwith the text when the value it reads is not a whole number. Nothing wraps it, so the error recorded forjsonbundlercarries the text as it is.fails with an error and sets no JSONinpipeline/fiftyone.pipeline.core/tests/jsonBuilderSequence.test.jslines 54 to 64 now asserts the recorded error's message withtoBeagainst the exact text, where it matched/Sequence Element/before, which the old wording also passed.Tests and builds
expect(received).toBe(expected)fails in that one test (1 failed, 8 passed), expecting the text.Setting 'PullRequestSha'line in its job logs (7 of them) reads a7bb064. macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.What remains
specifications#139, which states the text, has merged into rc as d72eb074. The same text goes into the other languages in 51degrees-dotnet#135, 51degrees-java#104, 51degrees-python#101, 51degrees-php#69, 51degrees-go#100 and 51degrees-rust#383. Nothing else is outstanding here.