Skip to content

Wait for the watcher's update in the watcher test, not the polling timer's check #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwrosewell merged 2 commits into from
Nov 10, 2026
Merged

Wait for the watcher's update in the watcher test, not the polling timer's check #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c9936a
Wait for the watcher's update in the watcher test, not the polling ti…
jwrosewell Nov 9, 2026
4eb2d3a
Import AUTO_UPDATE_SUCCESS in the data update service tests
jwrosewell Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...line.engines/src/test/java/fiftyone/pipeline/engines/services/DataUpdateServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@

import static fiftyone.pipeline.engines.services.DataUpdateService.AutoUpdateStatus.AUTO_UPDATE_HTTPS_ERR;
import static fiftyone.pipeline.engines.services.DataUpdateService.AutoUpdateStatus.AUTO_UPDATE_NOT_NEEDED;
import static fiftyone.pipeline.engines.services.DataUpdateService.AutoUpdateStatus.AUTO_UPDATE_SUCCESS;
import static org.junit.Assert.*;
import static org.junit.Assume.assumeFalse;
import static org.mockito.Mockito.*;
Expand Down Expand Up @@ -415,14 +416,17 @@ public Object answer(InvocationOnMock invocationOnMock) throws Throwable {
}
});

// Configure a flag to be set when processing
// is complete.
// Configure a flag to be set when the watcher has applied the
// update. The polling timer's own check also completes, with no
// update found, and must not release the flag.
final Semaphore completeFlag = new Semaphore(1);
completeFlag.acquire();
dataUpdate.onUpdateComplete(new OnUpdateComplete() {
@Override
public void call(Object sender, DataUpdateService.DataUpdateCompleteArgs args) {
completeFlag.release();
if (args.getStatus() == AUTO_UPDATE_SUCCESS) {
completeFlag.release();
}
}
});

Expand Down
Loading