Repository navigation
Give the pipeline developer examples the test resource key - #108
Merged
Merged
Conversation
The integration step runs the pipeline developer examples' ExampleTests again without the key the unit test run passes, and the cloud engine example's test now fails when it has no key rather than skipping, so every full build failed there. The step now passes -DTestResourceKey as the example build below it does.
jwrosewell
marked this pull request as ready for review
November 11, 2026 17:47
This was referenced Nov 11, 2026
Move cxx to the 51degrees-cxx release 4.5.105 and read by index on an engine built with no names
#82
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Every Java full build fails at "Pipeline developer examples" since #59 merged, whatever the pull request changes. In the full build of #79, run 43051980968, Ubuntu Java 17 failed there with:
and the other eight jobs were cancelled with it.
ci/run-integration-tests.ps1runs the pipeline developer examples'ExampleTestsa second time, after the unit test run has already run them with-DTestResourceKey=$TestResourceKey, and the second run passed no key (line 36 at cf7e5e28). Before #59 the cloud engine example's test skipped when it had no key, so the second run passed. #59 makes a cloud test fail rather than pass without calling the cloud, so the second run now fails.What changes
ci/run-integration-tests.ps1passes"-DTestResourceKey=$TestResourceKey"to thatmvn test, as the example build further down the same script does (line 62) and asci/run-unit-tests.ps1does. The cloud engine example'sMainreadsTestResourceKeyas an environment variable or a system property, and Surefire hands the Maven property to the tests as a system property.I checked every other
mvnrun underci/.build-project.ps1,build-package-requirements.ps1and the package step skip tests, the unit test run passes the key, and the two performance runs (*ShareUsageOverheadTests*and*Performance*) call no cloud service. So this is the only test run that started a cloud example without the key.How it was checked
Each test run is a throwaway branch with a temporary workflow that builds the pipeline reactor and runs the step's
mvn test -Dtest=ExampleTestson Ubuntu with Java 17.rcSimpleCloudEngine_Testfails with the message above, 1 of 1 inpipeline.developerexamples.cloudengine.ExampleTests-DTestResourceKeySimpleCloudEngine_Testpasses, and the build succeedsrcat cf7e5e2. All 9 jobs without macOS passed, being Ubuntu Java 8, 11, 17 and 21, Ubuntu ARM Java 17, and Windows Java 8, 11, 17 and 21, andpipeline.developerexamples.cloudengine.ExampleTestspassed in the integration step. EverySetting 'PullRequestSha'line, in Configure and in each of the 9 jobs, is ec7bc30, and Configure printed "Left out 6 macOS entries"macOS was left out of this draft's full build under the 9 November decision. The rc head is built with macOS before it merges into main.
What remains
Nothing for this change. Every Java draft built on
rcfrom cf7e5e2 until this merges fails at the same step, so #79, #97, #102 and #107 build after it.Version
No version change.