Chore/trim datepicker review comments - #86
Merged
Conversation
0960a11 and d76845a piled multi-paragraph docblocks onto small pieces of logic (typingSlots alone had ~25 lines across two paragraphs) — too long to actually get read. Same content, compressed to what the next reader needs, in ui-datepicker.ts, mask-engine.ts, and their spec files. No behavior change.
The Changed entry for allowInput's default (still true) said range/ multiple stay read-only — true when written, but the Added entry right above it (and the code: triggerReadonly no longer tests selectionMode) already documents that both are covered now. Spotted in passing while working on a separate ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.