FSHSP-118 fix(ui-datepicker): stop the field click from stealing focu… - #85
Merged
Conversation
…s to the grid open()'s rove-into-grid used to key off `selectionMode() !== 'single'` — meant to restore the calendar icon's own behavior (icon click = "I want the grid") after range/multiple stopped being hardcoded read-only. But the wrapper's (click)="open()" fires on ANY click in the field, including the click meant to place the caret and start typing — so the moment range got its own live mask, clicking the field to type immediately roved focus back out into the grid, making typing impossible. open() now takes a viaIcon flag (threaded through toggle()): the calendar icon passes true and still roves; the field's own click passes nothing and keeps focus in the input, in every mode, matching single's pre-existing behavior. Verified live in Storybook: field click keeps focus on the input, icon click still roves to the selected grid cell.
LBU4SH
force-pushed
the
fix/range-field-click-opens-grid
branch
from
August 24, 2026 18:15
fd03119 to
56ab2c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s to the grid
open()'s rove-into-grid used to key off
selectionMode() !== 'single'— meant to restore the calendar icon's own behavior (icon click = "I want the grid") after range/multiple stopped being hardcoded read-only. But the wrapper's (click)="open()" fires on ANY click in the field, including the click meant to place the caret and start typing — so the moment range got its own live mask, clicking the field to type immediately roved focus back out into the grid, making typing impossible.open() now takes a viaIcon flag (threaded through toggle()): the calendar icon passes true and still roves; the field's own click passes nothing and keeps focus in the input, in every mode, matching single's pre-existing behavior. Verified live in Storybook: field click keeps focus on the input, icon click still roves to the selected grid cell.