Repository navigation
Fix CLI apply outcomes, model precedence and concurrent cache writes - #34
Merged
Merged
Conversation
This was referenced Nov 9, 2026
mikkel
marked this pull request as ready for review
November 9, 2026 04:29
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI could report success and exit 0 after one or more smart-apply files failed, and patchling-apply --model was parsed into an attribute the applier never used. Concurrent disk-cache writers could also lose each other's records.
Aggregate per-file outcomes now drive both CLI exit statuses and summaries, including unsafe paths, read/write/delete errors, refusals and empty/invalid diffs. The standalone apply command forwards --model with CLI > environment > default precedence. Cache flushes merge only dirty records under the same local-filesystem claim protocol used by the JS SDK, retaining pending records after failure.
Validation:
Compatibility / release:
Existing parsing/release/UTF-8/binary fixes and draft documentation/deployment PRs are not duplicated. Related drafts: 255BITS/patchling#16 and 255BITS/patchling-examples#6. Both push and PR Core API Tests runs passed (42554550372 and 42554574685).