Repository navigation
fix(macos): 拆分超限的 AppModel+CodeNavigation 扩展以恢复 verify-core 门禁 - #1760
Merged
Merged
Conversation
将前进/后退历史与编辑器位置跳转部分原样移到 AppModel+NavigationHistory.swift, 不改行为、签名与可见性。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1lck
force-pushed
the
fix/appmodel-code-navigation-size
branch
from
November 5, 2026 09:15
f7c0c4d to
a38c9b0
Compare
Owner
Author
本地验证(代替 GitHub macOS / Windows CI)本 PR 与 #1760、#1755、#1753、#1759、#1756、#1758、#1757 一起,在本地集成分支 macOS(本机,macOS 26.6 arm64)
Windows(lithe-dev,Windows Server)
合并前每个 PR 已 rebase 到最新 preview,并重新执行编译、i18n、 |
1lck
marked this pull request as ready for review
November 5, 2026 09:15
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原因
#1730 合入后
AppModel+CodeNavigation.swift达到 627 行,超过verify-service-boundaries.sh对单个 AppModel 扩展 600 行的上限,导致所有 PR 的 CI 失败。拆分方式
把前进/后退历史(
canNavigateBack/Forward、navigateBack/Forward)以及编辑器位置跳转(navigateToEditorLocation、navigate(to:recordsHistory:replaysHistory:)、私有的currentEditorNavigationLocation)原样移到同目录新文件AppModel+NavigationHistory.swift。原文件 502 行,新文件 134 行。行为
纯代码移动,未改行为、签名和访问级别(私有函数与其唯一调用者同在新文件内)。未改动门禁脚本,也没有加豁免。
验证
verify-core.sh、verify-service-boundaries.sh通过node scripts/i18n/verify-app-language-localization.mjs通过swift build(macos/)通过🤖 Generated with Claude Code