You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Document the label-first, ID-fallback lookup behavior in USAGE.md.
Add regression coverage for load_dict, load, and label-vs-ID collision precedence.
Why
opfield currently only matches field.label, so configurations cannot reference stable 1Password field IDs when labels differ or are user-facing. This adds the fallback requested in #50 while keeping label lookup precedence for backwards compatibility.
⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).
If you're new to commit signing, there are different ways to set it up:
Sign commits with gpg
Follow the steps below to set up commit signing with gpg:
Closing this because this repository requires commits to be signed by a GitHub-recognized signing key, and I do not currently have a signing key registered for this account in this environment. I do not want to leave an unmergeable PR open. The implementation remains available on the branch if useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_dictandloadopfieldlookups by field label first, then by field ID as a fallback.USAGE.md.load_dict,load, and label-vs-ID collision precedence.Why
opfieldcurrently only matchesfield.label, so configurations cannot reference stable 1Password field IDs when labels differ or are user-facing. This adds the fallback requested in #50 while keeping label lookup precedence for backwards compatibility.Fixes #50.
Test plan
test_load_dict_resolves_field_by_id_when_label_differstest_load_resolves_field_by_id_when_label_differspython3 -m pytest src/tests/test_config.py -q— 6 passedpython3 -m pytest src/tests -q— 55 passed, 1 existing pytest warningpython3 -m py_compile src/onepasswordconnectsdk/config.py src/tests/test_config.pygit diff --check