fix: resolve config fields by id fallback#145
Closed
kocaemre wants to merge 0 commit into
Closed
Conversation
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
kocaemre
force-pushed
the
fix/load-field-id
branch
from
July 26, 2026 17:17
f9203c6 to
ddf9a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_dictandloadopfieldlookups by field label first, then by field ID as a fallback.USAGE.md.load_dict,load, and label-vs-ID collision precedence.Why
opfieldcurrently only matchesfield.label, so configurations cannot reference stable 1Password field IDs when labels differ or are user-facing. This adds the fallback requested in #50 while keeping label lookup precedence for backwards compatibility.Fixes #50.
Test plan
test_load_dict_resolves_field_by_id_when_label_differstest_load_resolves_field_by_id_when_label_differspython3 -m pytest src/tests/test_config.py -q— 6 passedpython3 -m pytest src/tests -q— 55 passed, 1 existing pytest warningpython3 -m py_compile src/onepasswordconnectsdk/config.py src/tests/test_config.pygit diff --check