Skip to content

fix: add form data filtering to exclude internal context keys #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaohuzhang1 wants to merge 1 commit into from
Closed

fix: add form data filtering to exclude internal context keys #7498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion apps/application/flow/step_node/form_node/impl/base_form_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,20 @@
'MultiSelect',
'MultiRow'
]
FORM_CONTEXT_KEYS = {
'result', 'form_content_format', 'form_field_list', 'form_data', 'is_submit',
'exception_message', 'start_time', 'run_time',
}


def filter_form_data(form_data, field_names):
if form_data is None:
return None
if not isinstance(form_data, dict):
return {}
# Only declared values may enter the context; internal state is never a form field.
allowed_fields = {name for name in field_names if isinstance(name, str)} - FORM_CONTEXT_KEYS
return {key: value for key, value in form_data.items() if key in allowed_fields}


def get_default_option(option_list, _type, value_field):
Expand Down Expand Up @@ -63,7 +77,9 @@ def generate_prompt(workflow_manage, _value):

class BaseFormNode(IFormNode):
def save_context(self, details, workflow_manage):
form_data = details.get('form_data', None)
form_data = filter_form_data(
details.get('form_data'), (field.get('field') for field in (details.get('form_field_list') or []))
)
self.context['result'] = details.get('result')
self.context['form_content_format'] = details.get('form_content_format')
self.context['form_field_list'] = details.get('form_field_list')
Expand Down Expand Up @@ -166,6 +182,9 @@ def replacer(match):
return value

def execute(self, form_field_list, form_content_format, form_data, **kwargs) -> NodeResult:
form_data = filter_form_data(
form_data, (generate_prompt(self.workflow_manage, field.get('field')) for field in form_field_list)
)
if form_data is not None:
self.context['is_submit'] = True
self.context['form_data'] = form_data
Expand Down
Loading