Skip to content

fix(i18n): correct broken keys and mistranslations in en-US/zh-Hant locales - #6746

Open
simpleqt wants to merge 2 commits into
1Panel-dev:v2from
simpleqt:fix-en-us-zh-hant-locale-typos
Open

fix(i18n): correct broken keys and mistranslations in en-US/zh-Hant locales#6746
simpleqt wants to merge 2 commits into
1Panel-dev:v2from
simpleqt:fix-en-us-zh-hant-locale-typos

Conversation

@simpleqt

Copy link
Copy Markdown

Summary

All verified at HEAD:

  • ui/src/locales/lang/{en-US,zh-Hant}/workflow.ts: the showCondition/hideCondition keys contained an invisible U+200C zero-width non-joiner, so the lookups in Constructor.vue (workflow.nodes.baseNode.visibilitySetting.showCondition/hideCondition) fell through and the Visibility Setting dialog rendered the raw key instead of "Show Condition"/"Hide Condition". Removed the U+200C from both locales (zh-CN is clean).
  • en-US/common.ts: task status STARTED was translated as 'Padding'; zh-CN/zh-Hant say 执行中/執行中 → 'Running'. Shown in the execution-record drawers.
  • en-US/workflow.ts:
    • initiator: 'Iniiator' → 'Initiator' (column header in execution records)
    • restoreVersion: 'Restore Previous Version"' — stray trailing quote rendered on three workflow pages
    • 'Wireless loop must have a Break node' → 'Infinite loop...' (无限循环; the same file already uses 'Infinite Loop' for infiniteLoop)

jindou and others added 2 commits August 23, 2026 14:12
- README.md language switcher used href="/README_CN.md" and
  href="/README.md"; on GitHub absolute paths resolve against the
  domain, not the repo, so both 404. Drop the leading slash so they
  resolve to the sibling files in the repository root.
- ui/public/tool/*/detail.md referenced screenshots via
  /admin/tool/img/*.jpg. The images actually live in ui/public/tool/img/
  and the /admin/ prefix is host-absolute: it only happens to work in a
  default MaxKB deployment (ADMIN_PATH=/admin) and breaks on GitHub or
  any custom ADMIN_PATH. Replace with relative ../img/ paths that point
  at the real files in the repo.
…ocales

- workflow.ts (en-US, zh-Hant): the showCondition/hideCondition keys
  contained an invisible U+200C zero-width non-joiner, so lookups from
  Constructor.vue fell through and the Visibility Setting dialog rendered
  the raw key instead of 'Show Condition'/'Hide Condition'
- common.ts (en-US): task status STARTED was translated as 'Padding';
  zh-CN/zh-Hant say 执行中/執行中 (Running)
- workflow.ts (en-US): 'Iniiator' -> 'Initiator'; stray trailing quote in
  'Restore Previous Version"' rendered on three workflow pages;
  'Wireless loop' -> 'Infinite loop' (无限循环), consistent with
  infiniteLoop elsewhere in the same file
Copilot AI lite review requested due to automatic review settings August 23, 2026 11:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants