Harden and polish buffer.lol - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The live review found that robots.txt and sitemap.xml returned 404, several labels implied ICMP behavior that the browser tools do not perform, successful backend output was mostly raw JSON, and important server boundaries needed tighter enforcement. The previous Docker image also copied the full build tree and ran as root.
Impact
The UI remains intentionally small, but tool descriptions and results are clearer. Production deployments now fail closed when the diagnostics worker token is missing. Proxy-derived client IPs are trusted only when explicitly configured.
Before deployment, confirm the VPS sets:
TRUST_PROXY_HEADERS=truebehind CaddyDIAGNOSTICS_WORKER_TOKENValidation
npm ci