Conversation
0xdewy
force-pushed
the
release/multicall-hardening
branch
from
September 6, 2026 06:25
ad1bcc1 to
6415764
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return-value chaining could splice the wrong calldata, accept insufficient return data, and leave funds in a permissionless executor; the previous EIP-7702 authorization path did not securely bind the executed batch. This PR hardens execution and both builders, adds a read-only executor, and prepares a tested release candidate while keeping all nine write-execution benchmarks at or below the previous-code baseline.
What changed
Breaking changes and rollout
execute(address[],uint256[],bytes[],uint256[])becomesexecute(address[],uint256[],bytes,uint256[]). The byte buffer contains[length][calldata padded to 32]frames. Regenerate saved batches; the JavaScript package moves to version 2.SECURITY.md. Removing delegation preserves storage and does not cancel unused signatures after restoration.Resultfromdecode_partial_return.DEPLOY_7702=falseby default). Independent review is still required before treating it as production wallet infrastructure. Mainnet deployment, package publication, and an independent audit are outside this PR.Verification
Reproduce with:
Plain
forge testskips the two fork swaps withoutETH_RPC_URL; the rehearsal runs them. No live-mainnet transaction or independent audit was performed. This is not a claim of unconditional safety or globally optimal gas.Reviewer notes
Start with the executor bounds and copy logic, delegate authorization and nonce storage, then builder position calculations and adversarial tests. Schema mirrors, golden vectors, and gas snapshots support those changes. Most deleted lines are obsolete documentation, research outputs, and superseded examples rather than production code.