Skip to content

Commit 73c87fb

Browse files
committed
Use GNU make 4.2 on manylinux2014
libiconv 1.19's po/Makefile uses the '!=' shell assignment, which needs GNU make >= 4.0. CentOS 7 ships make 3.82, so all manylinux2014 builds fail with 'missing separator'. Install devtoolset-10-make, which is already first on the image's PATH.
1 parent b08a0f0 commit 73c87fb

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

‎.github/scripts/manylinux_build_and_test.sh‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,13 @@ case "$MANYLINUX_IMAGE" in
2525
yum install -y perl-core
2626
;;
2727
esac
28+
# libiconv >= 1.19 needs GNU make >= 4.0 (po/Makefile uses '!='); CentOS 7 ships 3.82.
29+
case "$MANYLINUX_IMAGE" in
30+
manylinux2014_*)
31+
yum install -y devtoolset-10-make
32+
make --version | head -n 1
33+
;;
34+
esac
2835

2936
# Step: Build lxml from source with static deps (temporary)
3037
# TODO: remove once lxml publishes cp315 manylinux2014_x86_64 wheels.

0 commit comments

Comments
 (0)