RFC: Allow admins to override/extend the default pipeline config #6576
Replies: 2 comments 1 reply
-
|
I would say just add a flag |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
This is actually a duplicate of #5428 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
woodpecker/shared/constant/constant.go
Lines 19 to 25 in c1adf2e
I've created a jsonnet extension I plan to use, however right now (as far as I can tell) you need to manually set each repo to check for e.g.
.woodpecker.jsonnet.Assuming this would be useful for anyone else making config extensions, it would be great if the admin could override or extend the list of default paths to look for. I think I would prefer extending over overriding, but I've mentioned it in case anyone disagrees.
Just wanted to open a discussion before working on a PR, but I believe it should more or less be a matter of extending the array (using a slice instead) in the above linked file.
Whether it should also be reflected in the help text might be a bit trickier.
My thought is to just allow for
WOODPECKER_EXTRA_DEFAULT_PIPELINE_CONFIGS="foo.jsonnet,bar.star".The array will need to be converted to a slice, but a quick search leads me to believe that should not affect anything. The PR that added it didn't have any specific reason to make it an array.
Beta Was this translation helpful? Give feedback.
All reactions