Skip to content

split_cflags docstring implies plain split is correct #22

Description

@MarkAtwood

share/gen-sbom split_cflags argues correctly against shlex (it eats backslashes out of Windows paths, so C:\Users\ci\sdk becomes C:Userscisdk and then evades the absolute-path scrub) and then leaves the reader believing plain .split() is right.

It isn't. Plain split breaks -DMSG="hello world" and -I"/opt/my sdk/inc" into two tokens each.

The docstring should name that limitation out loud and point at --cflags-file.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions