From bac36cd56cd38c6f6e9dde334d1c81d7e9819a74 Mon Sep 17 00:00:00 2001
From: zerone0x <39543393+zerone0x@users.noreply.github.com>
Date: Tue, 3 Nov 2026 16:49:13 +0000
Subject: [PATCH] fix(oxc): keep overview working when latest versions are
 unreachable

The overview RPC fetched the latest Oxlint/Oxfmt versions from
npm.antfu.dev without error handling, so any network failure made the
whole overview reject with "fetch failed". The lookup is now
best-effort (timeout, response.ok check, try/catch); when it fails,
`latest` is left unknown and the panel hides the version badge.

Fixes #626
---
 packages/oxc/src/app/pages/index.vue          |  1 +
 .../oxc/src/node/__tests__/overview.test.ts   | 67 +++++++++++++++++++
 .../oxc/src/node/rpc/functions/overview.ts    | 48 +++++++++++--
 3 files changed, 109 insertions(+), 7 deletions(-)
 create mode 100644 packages/oxc/src/node/__tests__/overview.test.ts

diff --git a/packages/oxc/src/app/pages/index.vue b/packages/oxc/src/app/pages/index.vue
index 5b2d8f10..57fba0a4 100644
--- a/packages/oxc/src/app/pages/index.vue
+++ b/packages/oxc/src/app/pages/index.vue
@@ -137,6 +137,7 @@ const tools = computed(() => {
             </div>
             <template v-if="tool.info.installed">
               <a
+                v-if="tool.info.latest !== undefined"
                 :href="
                   tool.info.latest ? undefined : `https://npmx.dev/package/${tool.id}/v/latest`
                 "
diff --git a/packages/oxc/src/node/__tests__/overview.test.ts b/packages/oxc/src/node/__tests__/overview.test.ts
new file mode 100644
index 00000000..38640b08
--- /dev/null
+++ b/packages/oxc/src/node/__tests__/overview.test.ts
@@ -0,0 +1,67 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { fetchLatestVersions, overview } from '../rpc/functions/overview'
+
+vi.mock('@vitejs/devtools-kit/node', () => ({ isVitePlusInstalled: () => true }))
+vi.mock('../utils/vite-plus', () => ({
+  getVitePlusVersions: async () => ({ vitePlus: '0.2.4', oxlint: '1.72.0', oxfmt: '0.57.0' }),
+}))
+vi.mock('../rpc/functions/oxlint-setup', () => ({ needsOxlintMigration: () => false }))
+
+const fetchMock = vi.fn<typeof fetch>()
+
+function runOverview() {
+  const setup = overview.setup!({ cwd: '/project' } as any)
+  return setup.handler!()
+}
+
+beforeEach(() => {
+  vi.stubGlobal('fetch', fetchMock)
+})
+
+afterEach(() => {
+  fetchMock.mockReset()
+  vi.unstubAllGlobals()
+})
+
+describe('fetchLatestVersions', () => {
+  it('returns the latest published versions', async () => {
+    fetchMock.mockResolvedValue(Response.json([{ version: '1.72.0' }, { version: '0.58.0' }]))
+
+    await expect(fetchLatestVersions()).resolves.toEqual({ oxlint: '1.72.0', oxfmt: '0.58.0' })
+  })
+
+  it('returns unknown versions when the request fails', async () => {
+    fetchMock.mockRejectedValue(new TypeError('fetch failed'))
+
+    await expect(fetchLatestVersions()).resolves.toEqual({ oxlint: undefined, oxfmt: undefined })
+  })
+
+  it('returns unknown versions on a non-OK response', async () => {
+    fetchMock.mockResolvedValue(new Response('Bad Gateway', { status: 502 }))
+
+    await expect(fetchLatestVersions()).resolves.toEqual({ oxlint: undefined, oxfmt: undefined })
+  })
+})
+
+describe('overview', () => {
+  it('compares local versions with the latest versions', async () => {
+    fetchMock.mockResolvedValue(Response.json([{ version: '1.72.0' }, { version: '0.58.0' }]))
+
+    const result = await runOverview()
+
+    expect(result.oxlint).toMatchObject({ installed: true, version: '1.72.0', latest: true })
+    expect(result.oxfmt).toMatchObject({ installed: true, version: '0.57.0', latest: false })
+  })
+
+  it('still reports local versions when the latest versions are unreachable', async () => {
+    fetchMock.mockRejectedValue(new TypeError('fetch failed'))
+
+    const result = await runOverview()
+
+    expect(result).toMatchObject({
+      oxlint: { installed: true, version: '1.72.0', latest: undefined },
+      oxfmt: { installed: true, version: '0.57.0', latest: undefined },
+      vitePlus: '0.2.4',
+    })
+  })
+})
diff --git a/packages/oxc/src/node/rpc/functions/overview.ts b/packages/oxc/src/node/rpc/functions/overview.ts
index 694f387a..2b61a5a0 100644
--- a/packages/oxc/src/node/rpc/functions/overview.ts
+++ b/packages/oxc/src/node/rpc/functions/overview.ts
@@ -7,10 +7,45 @@ import { needsOxlintMigration } from './oxlint-setup'
 type Package = {
   installed: boolean
   version: string | undefined
-  latest: boolean
+  /** `undefined` when the latest version could not be determined. */
+  latest: boolean | undefined
   npmxLink: string | undefined
 }
 
+type LatestVersions = {
+  oxlint: string | undefined
+  oxfmt: string | undefined
+}
+
+const LATEST_VERSIONS_URL = 'https://npm.antfu.dev/oxlint+oxfmt'
+const LATEST_VERSIONS_TIMEOUT = 5000
+
+/**
+ * Best-effort lookup of the latest published Oxlint / Oxfmt versions.
+ * Resolves to `undefined` versions when the registry is unreachable so the
+ * overview can still render local toolchain info.
+ */
+export async function fetchLatestVersions(): Promise<LatestVersions> {
+  try {
+    const res = await fetch(LATEST_VERSIONS_URL, {
+      signal: AbortSignal.timeout(LATEST_VERSIONS_TIMEOUT),
+    })
+    if (!res.ok) return { oxlint: undefined, oxfmt: undefined }
+    const data = await res.json()
+    const [oxlintData, oxfmtData] = Array.isArray(data) ? data : []
+    return {
+      oxlint: typeof oxlintData?.version === 'string' ? oxlintData.version : undefined,
+      oxfmt: typeof oxfmtData?.version === 'string' ? oxfmtData.version : undefined,
+    }
+  } catch {
+    return { oxlint: undefined, oxfmt: undefined }
+  }
+}
+
+function isLatest(version: string | undefined, latestVersion: string | undefined) {
+  return version && latestVersion ? version === latestVersion : undefined
+}
+
 export const overview = defineOxcRpc({
   name: 'devtools-oxc:overview',
   type: 'query',
@@ -31,8 +66,7 @@ export const overview = defineOxcRpc({
           npmxLink: undefined,
         }
 
-        const res = await fetch('https://npm.antfu.dev/oxlint+oxfmt')
-        const [oxlintData, oxfmtData] = await res.json()
+        const latestVersions = await fetchLatestVersions()
         const vitePlus = isVitePlusInstalled(ctx.cwd)
         const vitePlusVersions = vitePlus ? await getVitePlusVersions(ctx.cwd) : undefined
 
@@ -40,13 +74,13 @@ export const overview = defineOxcRpc({
           oxlint = {
             installed: true,
             version: vitePlusVersions.oxlint,
-            latest: vitePlusVersions.oxlint === oxlintData.version,
+            latest: isLatest(vitePlusVersions.oxlint, latestVersions.oxlint),
             npmxLink: `https://npmx.dev/package/oxlint/v/${vitePlusVersions.oxlint}`,
           }
           oxfmt = {
             installed: true,
             version: vitePlusVersions.oxfmt,
-            latest: vitePlusVersions.oxfmt === oxfmtData.version,
+            latest: isLatest(vitePlusVersions.oxfmt, latestVersions.oxfmt),
             npmxLink: `https://npmx.dev/package/oxfmt/v/${vitePlusVersions.oxfmt}`,
           }
         } else {
@@ -57,7 +91,7 @@ export const overview = defineOxcRpc({
             }
             oxlint.installed = true
             oxlint.version = stdout.split(' ')[1]?.trim().replaceAll('\n', '') ?? undefined
-            oxlint.latest = oxlint.version === oxlintData.version
+            oxlint.latest = isLatest(oxlint.version, latestVersions.oxlint)
             oxlint.npmxLink = `https://npmx.dev/package/oxlint/v/${oxlint.version}`
           } catch {
             oxlint.installed = false
@@ -69,7 +103,7 @@ export const overview = defineOxcRpc({
             }
             oxfmt.installed = true
             oxfmt.version = stdout.split(' ')[1]?.trim().replaceAll('\n', '') ?? undefined
-            oxfmt.latest = oxfmt.version === oxfmtData.version
+            oxfmt.latest = isLatest(oxfmt.version, latestVersions.oxfmt)
             oxfmt.npmxLink = `https://npmx.dev/package/oxfmt/v/${oxfmt.version}`
           } catch {
             oxfmt.installed = false