Soft redirects don't recount filters

[cD1rtX3]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• using a new, unmodified browser profile.

Description

When the page does a soft redirect, filters aren't recounted.

A specific URL where the issue occurs.

https://music.youtube.com/watch?v=dQw4w9WgXcQ

Steps to Reproduce

1. Add /music\.youtube\.com\/(?!watch).*/###player to your filters list. This should block the player on music.youtube.com, unless the file starts with watch.
2. Go to https://music.youtube.com/watch?v=dQw4w9WgXcQ or any other video page. The player is correctly not blocked.
3. Minimize the player page.

The miniplayer should be blocked but isn't.

4. Reload the page. This will put you on https://music.youtube.com.
5. Open a song.

The player is incorrectly hidden.

6. Minimize the player. The miniplayer is correctly hidden.

Configuration

Details

uBlock Origin: 1.73.0
Chromium: 151
filterset (summary):
 network: 182526
 cosmetic: 43683
 scriptlet: 37541
 html: 0
listset (total-discarded, last-updated):
 removed:
  FRA-0: null
 default:
  user-filters: 32-0, never
  ublock-filters: 53119-87, 5h.48m Δ
  ublock-badware: 10294-17, 5h.48m Δ
  ublock-privacy: 4138-4, 5h.48m Δ
  ublock-unbreak: 2803-1, 5h.48m Δ
  ublock-quick-fixes: 503-0, 5h.48m Δ
  easylist: 86919-484, 5h.48m Δ
  easyprivacy: 56455-742, 5h.48m Δ
  urlhaus-1: 47440-10, 9h.49m
  plowe-0: 3522-0, 8d.14m
filterset (user): [array of 32 redacted]
trustedset:
 added: [array of 4 redacted]
 removed:
  chrome-extension-scheme
switchRuleset:
 added: [array of 1 redacted]
userSettings:
 advancedUserEnabled: true
hiddenSettings: [none]
supportStats:
 allReadyAfter: 527 ms (selfie)
 maxAssetCacheWait: 131 ms
 cacheBackend: indexedDB

[cD1rtX3]

This wasn't filed under uAssets because this is an issue with the filter system, not a filter list. This wasn't filed under the YouTube issue because 1. this most likely isn't specific to YouTube; and 2. that page is on uAssets, but this is an issue with the core extension.

[gorhill]

Use :match-path(...) if you want to apply cosmetic filters according to URL path in the address bar:

music.youtube.com###player:matches-path(/^\/(?!watch)/)

Your filter is meant to apply only when the a navigation to a webpage which matches your regex occurs, not when the webpage visually update the URL address without navigation occurring.

One issue though is that the current :matches-path implementation doesn't react to URL address change events, because this was not available in browsers at time of :matches-path implementation. I will revise the implementation to now rely on navigation events. For now the workaround is to force refresh of procedural filters on attribute changes:

music.youtube.com###player:watch-attr():matches-path(/^\/(?!watch)/)

In any case, you can accomplish the same using plain CSS syntax, which is always preferable:

music.youtube.com##ytmusic-app-layout[player-ui-state="MINIPLAYER"] #player