Skip to content

Commit ad425cc

Browse files
committed
chore(webapp): refresh the run-ops legacy-guard baseline for the shard read
The baseline is keyed by line number, so partitioning the batch-results read by shard shifted the four pre-existing entries in ApiBatchResultsPresenter and added one. The new entry is the shard read beside the two gen-1 reads already in the baseline: the same explicitly-passed replica handle, the same read pattern. Net baselined violations in this file go from four to five, all reads, none new in kind.
1 parent 90ea1e0 commit ad425cc

1 file changed

Lines changed: 17 additions & 8 deletions

File tree

apps/webapp/app/v3/runOpsMigration/track1-baseline.json

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,19 +68,19 @@
6868
"WaitpointTag.project"
6969
],
7070
"totals": {
71-
"violations": 4,
72-
"detectorI": 4,
71+
"violations": 5,
72+
"detectorI": 5,
7373
"detectorII": 0,
7474
"detectorIII": 0,
7575
"write": 0,
76-
"read": 4,
76+
"read": 5,
7777
"files": 1,
7878
"legacyAnnotations": 0
7979
},
8080
"violations": [
8181
{
8282
"file": "apps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.ts",
83-
"line": 89,
83+
"line": 92,
8484
"model": "BatchTaskRun",
8585
"delegate": "batchTaskRun",
8686
"callKind": "read",
@@ -89,7 +89,7 @@
8989
},
9090
{
9191
"file": "apps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.ts",
92-
"line": 150,
92+
"line": 153,
9393
"model": "BatchTaskRun",
9494
"delegate": "batchTaskRun",
9595
"callKind": "read",
@@ -98,16 +98,25 @@
9898
},
9999
{
100100
"file": "apps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.ts",
101-
"line": 184,
101+
"line": 204,
102102
"model": "TaskRun",
103103
"delegate": "taskRun",
104104
"callKind": "read",
105105
"detector": "i",
106-
"snippet": "const newRows = (await newClient.taskRun.findMany({"
106+
"snippet": "? ((await newClient.taskRun.findMany({"
107107
},
108108
{
109109
"file": "apps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.ts",
110-
"line": 196,
110+
"line": 214,
111+
"model": "TaskRun",
112+
"delegate": "taskRun",
113+
"callKind": "read",
114+
"detector": "i",
115+
"snippet": "(await shardReplicas.get(shardKey)!.taskRun.findMany({"
116+
},
117+
{
118+
"file": "apps/webapp/app/presenters/v3/ApiBatchResultsPresenter.server.ts",
119+
"line": 231,
111120
"model": "TaskRun",
112121
"delegate": "taskRun",
113122
"callKind": "read",

0 commit comments

Comments
 (0)