Skip to content

Commit 8be00e1

Browse files
authored
Merge pull request #287 from thisisthepy/feat/compose-plugin-ext3
Build: bump org.thisisthepy.compose plugin to 1.11.1-ext.3
2 parents 9497acb + 4e50b6e commit 8be00e1

4 files changed

Lines changed: 9 additions & 8 deletions

File tree

‎.github/workflows/stubs.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Kotlin-name stubs
22

33
# Issue #32: pythonx-compose consumes the binder's Kotlin-name `.pyi` stubs for the real Compose jars
44
# but cannot run this repository's Gradle build. This job runs the stub task over the Compose version the
5-
# build resolves (`compose-plugin` in gradle/libs.versions.toml) and publishes the result.
5+
# build resolves (`compose-libraries` in gradle/libs.versions.toml) and publishes the result.
66
#
77
# - every push to develop and every pull request: the stubs are generated, type-checked against
88
# .github/scripts/stubs/consumer.py with mypy (issue #31), and uploaded as the workflow artifact `kotlin-stubs`;
@@ -54,7 +54,7 @@ jobs:
5454
- name: Assemble the artifact
5555
run: |
5656
set -euo pipefail
57-
compose_version="$(sed -nE 's/^compose-plugin = "([^"]+)".*/\1/p' gradle/libs.versions.toml)"
57+
compose_version="$(sed -nE 's/^compose-libraries = "([^"]+)".*/\1/p' gradle/libs.versions.toml)"
5858
test -n "$compose_version"
5959
out=build/kotlin-stubs
6060
rm -rf "$out"

‎gradle.properties‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ kotlin.native.binary.sourceInfoType=libbacktrace
2121
#Compose
2222
org.jetbrains.compose.experimental.jscanvas.enabled=true
2323
org.jetbrains.compose.experimental.uikit.enabled=true
24-
# org.thisisthepy.compose:compose-gradle-plugin:1.11.1-ext.2's Maven Central POM marks
24+
# org.thisisthepy.compose:compose-gradle-plugin:1.11.1-ext.3's Maven Central POM marks
2525
# hot-reload-gradle-plugin as optional (shadow configuration), so Gradle does not place it on the
2626
# plugin classpath unless disabled or declared separately.
2727
org.jetbrains.compose.hot.reload.disable=true

‎gradle/libs.versions.toml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ androidx-core-ktx = "1.13.1"
1010
androidx-espresso-core = "3.6.1"
1111
androidx-material = "1.12.0"
1212
androidx-test-junit = "1.2.1"
13-
compose-plugin = "1.11.1-ext.2"
13+
compose-plugin = "1.11.1-ext.3"
14+
compose-libraries = "1.11.1-ext.2"
1415
# JetBrains stopped publishing material-icons with Compose after 1.7.3 (Maven Central: newest is 1.7.3);
1516
# it is the version Compose Multiplatform 1.11.x points to, resolved against 1.11.1's ui/ui-graphics.
1617
compose-material-icons = "1.7.3"
@@ -33,8 +34,8 @@ androidx-appcompat = { group = "androidx.appcompat", name = "appcompat", version
3334
androidx-material = { group = "com.google.android.material", name = "material", version.ref = "androidx-material" }
3435
androidx-constraintlayout = { group = "androidx.constraintlayout", name = "constraintlayout", version.ref = "androidx-constraintlayout" }
3536
androidx-activity-compose = { module = "androidx.activity:activity-compose", version.ref = "androidx-activityCompose" }
36-
androidx-lifecycle-viewmodel = { group = "org.thisisthepy.compose.androidx.lifecycle", name = "lifecycle-viewmodel", version.ref = "compose-plugin" }
37-
androidx-lifecycle-runtime-compose = { group = "org.thisisthepy.compose.androidx.lifecycle", name = "lifecycle-runtime-compose", version.ref = "compose-plugin" }
37+
androidx-lifecycle-viewmodel = { group = "org.thisisthepy.compose.androidx.lifecycle", name = "lifecycle-viewmodel", version.ref = "compose-libraries" }
38+
androidx-lifecycle-runtime-compose = { group = "org.thisisthepy.compose.androidx.lifecycle", name = "lifecycle-runtime-compose", version.ref = "compose-libraries" }
3839
kotlinx-coroutines-swing = { group = "org.jetbrains.kotlinx", name = "kotlinx-coroutines-swing", version.ref = "kotlinx-coroutines" }
3940
kotlinx-browser = { group = "org.jetbrains.kotlinx", name = "kotlinx-browser", version.ref = "kotlinx-browser" }
4041

‎python-multiplatform-gradle-plugin/fixtures/artifact/build.gradle.kts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ kotlin {
6060
// `Composer` anywhere. Composables are a different problem
6161
// (`docs/archive/pythonx-adapter-design.md` §5) and are not touched here.
6262
//
63-
// Version pinned to the catalog's `compose-plugin`, which is what the rest of this
63+
// Version pinned to the catalog's `compose-libraries`, which is what the rest of this
6464
// build resolves, so no second Compose version enters the cache.
65-
val composeVersion = libs.versions.compose.plugin.get()
65+
val composeVersion = libs.versions.compose.libraries.get()
6666
implementation("org.thisisthepy.compose.ui:ui-desktop:$composeVersion")
6767
implementation("org.thisisthepy.compose.ui:ui-unit-desktop:$composeVersion")
6868
implementation("org.thisisthepy.compose.foundation:foundation-layout-desktop:$composeVersion")

0 commit comments

Comments
 (0)