Commit 2774722
committed
fix(taskless): close two holes the rules could not see through
From review of #187. Both findings verified before acting, and both real.
`ci-uses-workspace-cli` matched `npx @taskless/cli` and nothing else, so the
invocation CLAUDE.md names by name, `pnpm dlx @taskless/cli@latest`, went
straight through the rule written to forbid it. `yarn dlx` and a global install
did too. A rule that permits the exact string its own repository documents as
the thing to avoid is worse than no rule, because it reads as coverage.
Widening it to the bare package name overcorrected, and the dogfooding caught
that within one run: it fired on `pnpm --filter @taskless/cli build:nightly` in
`release-cli-nightly.yml`, which is the WORKSPACE package addressed as a
filter. `pnpm exec @taskless/cli` is the same story, running the local binary.
What separates a published build is being FETCHED, so the rule matches the
fetch verbs: `npx`, `dlx`, and `-g`. Fixtures now carry `pnpm dlx`, `yarn dlx`
and the two-step global install on the invalid side, and `pnpm exec` and
`--filter` on the valid side, so neither the hole nor the overcorrection can
come back. Measured: `pnpm dlx` and `npx` both exit 1, the clean tree exits 0.
`pr-workflow-ready-for-review` anchored on a `types:` node, so it only fired on
an explicit list that omitted `ready_for_review`. A `pull_request:` with no
`types:` at all falls through to GitHub's default set, which omits
`ready_for_review` just as surely — and the rule said nothing, because there
was no node to anchor to. That is the #103 gap the rule exists to prevent,
reachable by writing less rather than more.
It now also matches a `pull_request:` with no `types:` descendant. Nothing on
`main` hits it today (all three triggers declare `types:`), so this was latent;
a probe workflow with a bare `pull_request:` is now reported where it
previously was not. Severity stays `warning`, unchanged.1 parent fa9a4cd commit 2774722
4 files changed
Lines changed: 80 additions & 21 deletions
File tree
- .taskless/rules/sg
- ci-uses-workspace-cli
- .tests
- pr-workflow-ready-for-review
- .tests
Lines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
21 | 29 | | |
22 | 30 | | |
23 | 31 | | |
| |||
33 | 41 | | |
34 | 42 | | |
35 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
Lines changed: 20 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
20 | 36 | | |
21 | 37 | | |
22 | | - | |
| 38 | + | |
| 39 | + | |
23 | 40 | | |
24 | 41 | | |
25 | 42 | | |
| |||
43 | 60 | | |
44 | 61 | | |
45 | 62 | | |
46 | | - | |
| 63 | + | |
47 | 64 | | |
48 | | - | |
| 65 | + | |
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
Lines changed: 35 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
0 commit comments