From 25e31a3c650f59f143e50cc6a44c653f2bb71c79 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 24 Aug 2026 06:29:19 +0000 Subject: [PATCH] test: migrate `stats/base/dists/bradford/median` to ULP-based assertions Migrate the test suite from relative-tolerance comparisons to ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The tightest passing bound over the full fixture set is 14 ULPs. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01PpFyFNqQ3hZwejNzPP5VnD --- .../stats/base/dists/bradford/median/test/test.js | 13 ++----------- .../base/dists/bradford/median/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/bradford/median/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/bradford/median/test/test.js index 12e7ae682ec2..f7e408b600bb 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/bradford/median/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/bradford/median/test/test.js @@ -21,10 +21,9 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var median = require( './../lib' ); @@ -64,8 +63,6 @@ tape( 'if provided `c <= 0`, the function returns `NaN`', function test( t ) { tape( 'the function returns the median of a Bradford distribution', function test( t ) { var expected; - var delta; - var tol; var i; var c; var y; @@ -74,13 +71,7 @@ tape( 'the function returns the median of a Bradford distribution', function tes c = data.x; for ( i = 0; i < expected.length; i++ ) { y = median( c[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.2 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 14 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/bradford/median/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/bradford/median/test/test.native.js index 23a1385e6347..461c5d8adc82 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/bradford/median/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/bradford/median/test/test.native.js @@ -22,10 +22,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -88,8 +87,6 @@ tape( 'if provided `c <= 0`, the function returns `NaN`', opts, function test( t tape( 'the function returns the median of a Bradford distribution', opts, function test( t ) { var expected; - var delta; - var tol; var i; var c; var y; @@ -98,13 +95,7 @@ tape( 'the function returns the median of a Bradford distribution', opts, functi c = data.x; for ( i = 0; i < expected.length; i++ ) { y = median( c[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 7.2 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 14 ), true, 'returns expected value' ); } t.end(); });