Skip to content

Commit bd85cbb

Browse files
committed
style(eon): tighten recipe comments in fixtures and examples
1 parent 0f10ac5 commit bd85cbb

4 files changed

Lines changed: 4 additions & 14 deletions

File tree

‎examples/packages/companions/r/readcon-core/readcon-core-0.13.1-GCCcore-15.2.0.eb‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ preinstallopts += 'export CARGO_HOME=%(builddir)s/.cargohome && '
3333
install_cmd = 'cargo cinstall --locked --release --prefix %(installdir)s '
3434
install_cmd += '--libdir lib --includedir include --pkgconfigdir lib/pkgconfig'
3535

36-
# cargo-c does not go through EasyBuild RPATH link wrappers. The installed
37-
# lib only NEEDs libgcc_s + libc (no non-system deps). Do not invent RPATH
38-
# with patchelf; disable the readelf RPATH presence check instead.
36+
# cargo-c skips EB RPATH wrappers; lib only NEEDs libgcc_s/libc
3937
check_readelf_rpath = False
4038

4139
sanity_check_paths = {

‎fixtures/eon_core_rgpot/easyconfigs/e/eOn/eOn-2.17.2-foss-2026.1.eb‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ builddependencies = [
2424
('pkgconf', '2.5.1'),
2525
]
2626

27-
# Pure GCCcore libs: do not hard-code dep toolchain; robot walks foss subtoolchains.
2827
dependencies = [
2928
('Python', '3.14.2'),
3029
('SciPy-bundle', '2026.05'),
@@ -39,9 +38,7 @@ dependencies = [
3938
]
4039

4140
configopts = '-Dbuildtype=release -Dwith_tests=true -Dwith_rgpot=true'
42-
# 30/33 unit tests pass. Exclude 3 measured failures:
43-
# - test_si_pot / test_jobs: pot fixture paths (energy 0 / missing CWD data dirs)
44-
# - test_rgpot_pot: optional nwchemc/cpmdc engines not in this product (all SKIP)
41+
# Si pot / job fixtures need CWD data dirs; rgpot engine tests need external .so
4542
pretestopts = (
4643
"list=$(meson test -C %(builddir)s/easybuild_obj --list | "
4744
"grep -vE 'test_si_pot|test_jobs|test_rgpot_pot' | xargs) && "

‎fixtures/eon_core_rgpot/easyconfigs/r/readcon-core/readcon-core-0.13.1-GCCcore-15.2.0.eb‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ preinstallopts += 'export CARGO_HOME=%(builddir)s/.cargohome && '
3333
install_cmd = 'cargo cinstall --locked --release --prefix %(installdir)s '
3434
install_cmd += '--libdir lib --includedir include --pkgconfigdir lib/pkgconfig'
3535

36-
# cargo-c does not go through EasyBuild RPATH link wrappers. The installed
37-
# lib only NEEDs libgcc_s + libc (no non-system deps). Do not invent RPATH
38-
# with patchelf; disable the readelf RPATH presence check instead.
36+
# cargo-c skips EB RPATH wrappers; lib only NEEDs libgcc_s/libc
3937
check_readelf_rpath = False
4038

4139
sanity_check_paths = {

‎fixtures/eon_foss_2026_1/easyconfigs/e/eOn/eOn-2.17.2-foss-2026.1.eb‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ builddependencies = [
2424
('pkgconf', '2.5.1'),
2525
]
2626

27-
# Pure GCCcore libs: do not hard-code dep toolchain; robot walks foss subtoolchains.
2827
dependencies = [
2928
('Python', '3.14.2'),
3029
('SciPy-bundle', '2026.05'),
@@ -39,9 +38,7 @@ dependencies = [
3938
]
4039

4140
configopts = '-Dbuildtype=release -Dwith_tests=true -Dwith_rgpot=true'
42-
# 30/33 unit tests pass. Exclude 3 measured failures:
43-
# - test_si_pot / test_jobs: pot fixture paths (energy 0 / missing CWD data dirs)
44-
# - test_rgpot_pot: optional nwchemc/cpmdc engines not in this product (all SKIP)
41+
# Si pot / job fixtures need CWD data dirs; rgpot engine tests need external .so
4542
pretestopts = (
4643
"list=$(meson test -C %(builddir)s/easybuild_obj --list | "
4744
"grep -vE 'test_si_pot|test_jobs|test_rgpot_pot' | xargs) && "

0 commit comments

Comments
 (0)